Skip to content

reinstate basic_auth crawl protection for demo sites :| #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cziaarm wants to merge 3 commits into
base: main
Choose a base branch
from
Open

reinstate basic_auth crawl protection for demo sites :| #624

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3317489
reinstate basic_auth crawl protection for demo sites :|
cziaarm Jan 8, 2026
42776c5
remove now unecessary lint avoidance
cziaarm Jan 9, 2026
8a8104c
trailing bloomin whitespace
cziaarm Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/controllers/application_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,8 @@ def is_staging
def authenticate_if_needed
# Disable this extra authentication in test mode
return true if Rails.env.test?
return true # any hint of basic auth will stop BL staff from accessing site so instead we open all the "private" demo sites
if (is_hidden || is_staging) && !is_api_or_pdf # rubocop:disable Lint/UnreachableCode
#return true # any hint of basic auth will stop BL staff from accessing site so instead we open all the "private" demo sites
if (is_hidden || is_staging) && !is_api_or_pdf
authenticate_or_request_with_http_basic do |username, password|
username == ENV.fetch("HYKU_DEMO_USER", "bl_demo_user") && password == ENV.fetch("HYKU_DEMO_PASSWORD", "resu_omed_lb")
end
Expand Down
1 change: 1 addition & 0 deletions docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,7 @@ services:
## interact with the breakpoints.
##
# command: sh -l -c "bundle && tail -f /dev/null"
command: tail -f /dev/null
depends_on:
db:
condition: service_started
Expand Down
Loading