Skip to content

Updates to all the base ansible files in prep for nad cloud migration#1013

Merged
aprilrieger merged 17 commits intomainfrom
add-ansible-nadcloud-migration-support
Jan 12, 2026
Merged

Updates to all the base ansible files in prep for nad cloud migration#1013
aprilrieger merged 17 commits intomainfrom
add-ansible-nadcloud-migration-support

Conversation

@aprilrieger
Copy link
Copy Markdown
Member

Copy link
Copy Markdown
Member

@maxkadel maxkadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Approved with a couple non-blocking questions - definitely check the last one, though, before merging.


## Prerequisites

1. Clone the keep volume
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not currently know how I would do the first two clone steps, but I'm also not positive who the audience for this documentation is?

real_ip_recursive on;

server {
server_name b2.adventistdigitallibrary.org;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was surprised server_name wasn't a template variable - with NAD cloud as the provider maybe it will change rarely enough that we don't need it to be, just something to think about.

@aprilrieger aprilrieger changed the title Updates to all the base ansible files in prep for nad cloud migration DRAFT: Updates to all the base ansible files in prep for nad cloud migration Sep 17, 2025
@gitguardian
Copy link
Copy Markdown

gitguardian bot commented Nov 21, 2025

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
6293111 Triggered Generic Password f21e74f docker-compose.production.yml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@aprilrieger aprilrieger changed the title DRAFT: Updates to all the base ansible files in prep for nad cloud migration Updates to all the base ansible files in prep for nad cloud migration Jan 12, 2026
@aprilrieger aprilrieger merged commit a5722a0 into main Jan 12, 2026
4 of 6 checks passed
@aprilrieger aprilrieger deleted the add-ansible-nadcloud-migration-support branch January 12, 2026 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants