HOTFIX - DO NOT MERGE! Change nested collection query to use POST#1003
Closed
HOTFIX - DO NOT MERGE! Change nested collection query to use POST#1003
Conversation
The Nested Collection Controller is not based on catalog controller, so it does not inherit the POST behavior we added there. This is a temporary override until Hyrax supports POST for nested collection queries.
2 tasks
laritakr
added
Bug Fixing Sprint - Adventist
and removed
Contribute Back
sjproctor
temporarily deployed
to
production
GitHub Actions
Inactive
sjproctor
temporarily deployed
to
production
GitHub Actions
Inactive
sjproctor
temporarily deployed
to
production
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Nested Collection Controller is not based on catalog controller, so it does not inherit the POST behavior we added there. This causes the
parent_and_child_can_nest?to do a GET request, which fails when too many ids are included in the request.In this fix, we add an explicit setting of
http_methodprior to doing this query. This fix should be moved toHyrax::Collections::NestedCollectionQueryService, and removed here once that is complete.This is a temporary override until Hyrax code supporting POST for nested collection queries is brought forward, so it should not be merged.