Support Japanese button emojis (such as ㊗️) #31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EN
Note that even most browsing apps cannot display ㊗️
0x3297 0xFE0F
and ㊗0x3297
correctly.Expected behavior:
Actual behavior:
㊗, ㊙ are included in Unicode
0x3200
-0x32FF
Enclosed CJK Letters and Months, and 🈂, 🈚, 🈯, 🈷 are included in Unicode0x1F200
-0x1F2FF
Enclosed Ideographic Supplement, so I added the range0x3200
-0x32FF
and0x1F200
-0x1F2FF
to theemojiRange
array insrc/emoji.js
.P.S.
I noticed same issue also happens on some of these emoji (Unicode.org emoji-varians) which would be incorrectly splitted into a plain symbol and
0xFE0F
, so I assume there is a lot more things to do, but maybe not in this PR.JP
赤丸に白文字で㊗️の絵文字が「㊗
0x3297
」と「絵文字バリエーションシーケンス0xFE0F
」に分割されてしまっていたので、㊗, ㊙ を含むEnclosed CJK Letters and Monthsと同様の問題に遭遇している 🈂, 🈚, 🈯, 🈷 を含むEnclosed Ideographic Supplementをsrc/emoji.js
のemojiRange
に追加しました。