🐛 Filter out-of-month workdays from monthly work stats#37
Merged
Conversation
gdarquie
requested changes
Jul 15, 2026
gdarquie
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
end_workis called after midnight (crossing from the last day of the previous month into the first day of the current month), phantomStartWork/StopWorkannotations are written into the new month first note file but tagged with the previous month workday.These phantom annotations are found when computing the current month stats (they live in the current month folder) and counted as an extra work day, inflating
total_work_daysby 1.Fix
After grouping annotations by
workday, discard any entry whose workday does not belong to the requested month.Test
Added regression test
test_work_stats_no_extra_day_when_session_crosses_month_boundary.