-
Notifications
You must be signed in to change notification settings - Fork 223
feat: add the central server connection test to diagnostics page #3001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Refs: XRDDEV-2922
Job Summary for GradleBuild and test :: BuildAndPackageWithUnitTests
|
Job Summary for GradleBuild and test :: BuildAndPackageWithUnitTests
|
Eco CI Output - Old Energy EstimationEco CI Output [RUN-ID: 18308651011]: 🌳 CO2 Data: Total cost of whole PR so far:
|
|||||||||||||||||||||||||||||||||||||||||||||
Job Summary for GradleBuild and test :: BuildAndPackageWithUnitTests
|
Eco CI Output - Old Energy EstimationEco CI Output [RUN-ID: 18308651011]: 🌳 CO2 Data: Total cost of whole PR so far:
|
||||||||||||||||||||||||||||||||||||||||
Job Summary for GradleBuild and test :: BuildAndPackageOnArm
|
Eco CI Output - Old Energy EstimationEco CI Output [RUN-ID: 18308651011]: 🌳 CO2 Data: Total cost of whole PR so far:
|
||||||||||||||||||||||||||||||||||||||||
Eco CI Output - Old Energy EstimationEco CI Output [RUN-ID: 18308651011]: 🌳 CO2 Data: Total cost of whole PR so far:
|
||||||||||||||||||||||||||||||||||||||||
Eco CI Output - Old Energy EstimationEco CI Output [RUN-ID: 18308651011]: 🌳 CO2 Data: Total cost of whole PR so far:
|
||||||||||||||||||||||||||||||||||||||||
Job Summary for GradleBuild and test :: BuildAndPackageWithUnitTests
|
Eco CI Output - Old Energy EstimationEco CI Output [RUN-ID: 18315377443]: 🌳 CO2 Data: Total cost of whole PR so far:
|
|||||||||||||||||||||||||||||||||||||||||||||
Job Summary for GradleBuild and test :: BuildAndPackageWithUnitTests
|
Eco CI Output - Old Energy EstimationEco CI Output [RUN-ID: 18315377443]: 🌳 CO2 Data: Total cost of whole PR so far:
|
||||||||||||||||||||||||||||||||||||||||
Job Summary for GradleBuild and test :: BuildAndPackageOnArm
|
Eco CI Output - Old Energy EstimationEco CI Output [RUN-ID: 18315377443]: 🌳 CO2 Data: Total cost of whole PR so far:
|
||||||||||||||||||||||||||||||||||||||||
Eco CI Output - Old Energy EstimationEco CI Output [RUN-ID: 18315377443]: 🌳 CO2 Data: Total cost of whole PR so far:
|
||||||||||||||||||||||||||||||||||||||||
Eco CI Output - Old Energy EstimationEco CI Output [RUN-ID: 18315377443]: 🌳 CO2 Data: Total cost of whole PR so far:
|
||||||||||||||||||||||||||||||||||||||||
Job Summary for GradleBuild and test :: BuildAndPackageWithUnitTests
|
1 similar comment
Job Summary for GradleBuild and test :: BuildAndPackageWithUnitTests
|
Job Summary for GradleBuild and test :: BuildAndPackageWithUnitTests
|
2 similar comments
Job Summary for GradleBuild and test :: BuildAndPackageWithUnitTests
|
Job Summary for GradleBuild and test :: BuildAndPackageWithUnitTests
|
Job Summary for GradleBuild and test :: BuildAndPackageWithUnitTests
|
|
Eco CI Output [RUN-ID: 18503455300]: 🌳 CO2 Data: Total cost of whole PR so far:
|
||||||||||||||||||||||||||||||||||||||||
Job Summary for GradleBuild and test :: BuildAndPackageWithUnitTests
|
Job Summary for GradleBuild and test :: BuildAndPackageWithUnitTests
|
|
Eco CI Output [RUN-ID: 18562223082]: 🌳 CO2 Data: Total cost of whole PR so far:
|
|||||||||||||||||||||||||||||||||||||||||||||
Job Summary for GradleBuild and test :: BuildAndPackageWithUnitTests
|
|
Eco CI Output [RUN-ID: 18562223082]: 🌳 CO2 Data: Total cost of whole PR so far:
|
||||||||||||||||||||||||||||||||||||||||
Job Summary for GradleBuild and test :: BuildAndPackageOnArm
|
|
Eco CI Output [RUN-ID: 18562223082]: 🌳 CO2 Data: Total cost of whole PR so far:
|
||||||||||||||||||||||||||||||||||||||||
|
Eco CI Output [RUN-ID: 18562223082]: 🌳 CO2 Data: Total cost of whole PR so far:
|
||||||||||||||||||||||||||||||||||||||||
|
Eco CI Output [RUN-ID: 18562223082]: 🌳 CO2 Data: Total cost of whole PR so far:
|
||||||||||||||||||||||||||||||||||||||||
| try { | ||
| // the error is expected, but we want to verify that the connection can be established | ||
| managementRequestSenderService.sendAuthCertRegisterRequest(null, new byte[0], true); | ||
| throw new IllegalStateException("should not get here"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this throw feels misplaced here. sendAuthCertRegisterRequest is always expected to throw exception? If yes, then I think the method name could reflect this better - is it so that this method doesn't actually get auth cert registration status info, but rather checks connection?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not only connection, there are other verification as well
| @Override | ||
| @PreAuthorize("hasAuthority('DIAGNOSTICS')") | ||
| public ResponseEntity<ConnectionStatusDto> getAuthCertReqStatus() { | ||
| return new ResponseEntity<>(authCertStatusConverter.convert(diagnosticConnectionService.getAuthCertRegStatusInfo()), HttpStatus.OK); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Method name has req with a "q", but calls a method with reg with a "g". Is this correct?
|
|
Eco CI Output [RUN-ID: 18589694558]: 🌳 CO2 Data: Total cost of whole PR so far:
|
|||||||||||||||||||||||||||||||||||||||||||||
Job Summary for GradleBuild and test :: BuildAndPackageWithUnitTests
|
|
Eco CI Output [RUN-ID: 18589694558]: 🌳 CO2 Data: Total cost of whole PR so far:
|
||||||||||||||||||||||||||||||||||||||||
Job Summary for GradleBuild and test :: BuildAndPackageOnArm
|
|
Eco CI Output [RUN-ID: 18589694558]: 🌳 CO2 Data: Total cost of whole PR so far:
|
||||||||||||||||||||||||||||||||||||||||
|
Eco CI Output [RUN-ID: 18589694558]: 🌳 CO2 Data: Total cost of whole PR so far:
|
||||||||||||||||||||||||||||||||||||||||
|
Eco CI Output [RUN-ID: 18589694558]: 🌳 CO2 Data: Total cost of whole PR so far:
|
||||||||||||||||||||||||||||||||||||||||



Refs: XRDDEV-2922