Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #610 on prompting user they are not using an account capable of setting up AWS Organization #611

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

smoy
Copy link
Contributor

@smoy smoy commented Aug 23, 2023

What changed?

Rationale

  • User is informed they are not using the right AWS account when setting up AWS Organization.

How was it tested?

If it was manually verified, list the instructions for your reviewers to follow.

  • Unit Tests
  • Functional Tests
  • Manually Verified

export AWS env variable of a member account. get the message.

2023/08/23 14:30:28 [error    ] If you would like to use AWS Organizations, the IAMbic hub account you
configured must be the same AWS account as your AWS Organization.
Please follow AWS guide to setup an AWS organization first. If you already have an organization setup,
make sure you are using the organization management account before running IAMbic setup

export AWS env variable of a organization account, proceed as expected:

We recommend configuring IAMbic with AWS Organizations, but you may also manually configure accounts.
? What would you like to configure in AWS? AWS Organizations

What is the AWS Organization ID?
It can be found here https://us-east-1.console.aws.amazon.com/organizations/v2/home/accounts
? AWS Organization ID:  <redacted>

@smoy smoy self-assigned this Aug 23, 2023
Copy link
Contributor

@castrapel castrapel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Patch coverage has no change and project coverage change: -9.82% ⚠️

Comparison is base (2e003f7) 83.04% compared to head (ddc1e5a) 73.23%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #611      +/-   ##
==========================================
- Coverage   83.04%   73.23%   -9.82%     
==========================================
  Files         105      105              
  Lines       12587    12587              
==========================================
- Hits        10453     9218    -1235     
- Misses       2134     3369    +1235     
Flag Coverage Δ
functional_tests ?
functional_tests_config_discovery ?
unit_tests 73.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 51 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants