-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allowing search by 'Specification attribute name' in specification attributes page (Admin area) #7546
Open
qasas145
wants to merge
15
commits into
nopSolutions:develop
Choose a base branch
from
qasas145:feature-allow-search-by-name-admin-specification-attribute
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+289
−164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 2, 2025
e3652dc
to
65fb1a1
Compare
@RomanovM ,I Have updated this is PR , so we can search only by specification attribute name |
65fb1a1
to
603d0d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7545 i have added this feature by these steps
GetSpecificationAttributeGroupsAsync
in theISpecificationAttributeService.cs
file to have this signatureGetSpecificationAttributeGroupsAsync(int pageIndex = 0, int pageSize = int.MaxValue, string specificationName = "")
and this is to enable search by group name which contains this specification attributeGetSpecificationAttributesByGroupIdAsync
toGetSpecificationAttributesByGroupIdAsync(int? specificationAttributeGroupId = null, string name = "")
to enable searching by attribute name in the groupPrepareSpecificationAttributeGroupListModelAsync
in theSpecificationAttributeModelFactory
List.cshtml
to include search boxSpecificationAttributeSearchModel.cs
to include add searchName propertySpecificationAttributeGroupSearchModel.cs
to include specification attribute search propertySo this will be the page

You can type the attribute name and it will fetch the attribute and the group of it , and if it has no group then it appear in the default group
And you don't have to click on the control icon to display the result attributes , but the child table of specification attributes will open auto, so that you will see the attribute result directly
See images below


