fix(status): stop burning while standing in water - #171
Merged
Conversation
|
mparrett
marked this pull request as ready for review
July 22, 2026 16:24
mparrett
changed the title
mparrett
changed the title
nnunley
approved these changes
Jul 22, 2026
nnunley
left a comment
nnunley
left a comment
Collaborator
There was a problem hiding this comment.
I need to dig up my physics branch. I set up a multimap to indicate what should happen with different combined environment effects and a given cell
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
Fire runes applied
:burningdirectly after impact, bypassing the movement-time water extinguish logic. As a result, a player already standing in water could catch fire when hit by a fire imp. Forced fire ignition could also replace the water tile and leave a stale fire TTL entry.Players and creatures standing in shallow or deep water now remain unburned, while fire behavior on non-water terrain is unchanged.
Fixes #162.
Validation
/Users/matt/projects-new/3p/let-go/lg xsofy/test/run.lggit diff --checkTested with the new harness in #170