Skip to content

feat(input): bind Plan 9 arrow-key runes (fixes down-arrow in alacritty9) #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mparrett wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat(input): bind Plan 9 arrow-key runes (fixes down-arrow in alacritty9) #158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions xsofy/input.lg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,19 @@
(or (= (js/url-param "mode") "dev")
(let [e (os/getenv "XSOFY_DEV")] (and e (> (count e) 0)))))

;; Movement :keys carry both the ANSI arrow escapes and Plan 9's kernel arrow
;; runes (Kup U+F00E, Kdown U+F800, Kleft U+F011, Kright U+F012 —
;; /sys/include/keyboard.h). Which form a terminal delivers varies, so we bind
;; both: alacritty9 sends ANSI ESC[ for up/left/right but the raw Kdown rune for
;; DOWN (measured on 9front — down-movement in-game needs U+F800 or it's dead);
;; the bare text console sends all four as runes; rio's own windows swallow the
;; arrows for scrollback. Binding both forms makes movement work wherever a key
;; actually reaches us.
(def base-key-bindings
[{:action :up :category :movement :label "Move up" :keys ["\u001b[A" "k" "8"] :help-keys ["k" "8" "Up"]}
{:action :down :category :movement :label "Move down" :keys ["\u001b[B" "j" "2"] :help-keys ["j" "2" "Down"]}
{:action :left :category :movement :label "Move left" :keys ["\u001b[D" "h" "4"] :help-keys ["h" "4" "Left"]}
{:action :right :category :movement :label "Move right" :keys ["\u001b[C" "l" "6"] :help-keys ["l" "6" "Right"]}
[{:action :up :category :movement :label "Move up" :keys ["\u001b[A" "\uf00e" "k" "8"] :help-keys ["k" "8" "Up"]}
{:action :down :category :movement :label "Move down" :keys ["\u001b[B" "\uf800" "j" "2"] :help-keys ["j" "2" "Down"]}
{:action :left :category :movement :label "Move left" :keys ["\u001b[D" "\uf011" "h" "4"] :help-keys ["h" "4" "Left"]}
{:action :right :category :movement :label "Move right" :keys ["\u001b[C" "\uf012" "l" "6"] :help-keys ["l" "6" "Right"]}
{:action :up-left :category :movement :label "Move up-left" :keys ["y" "7"] :help-keys ["y" "7"]}
{:action :up-right :category :movement :label "Move up-right" :keys ["u" "9"] :help-keys ["u" "9"]}
{:action :down-left :category :movement :label "Move down-left" :keys ["b" "1"] :help-keys ["b" "1"]}
Expand Down
12 changes: 12 additions & 0 deletions xsofy/test/input_test.lg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,15 @@
(deftest unbound-keys-resolve-to-unknown
(testing "a nearby unbound key is :unknown, not a stray action"
(is (= :unknown (input/parse-key "Q")))))

(deftest plan9-arrow-runes-resolve-to-movement
(testing "Plan 9's bare-console arrow runes (rio sends these, not ANSI ESC[) map to movement"
(is (= :up (input/parse-key (str (char 0xf00e))))) ; Kup
(is (= :down (input/parse-key (str (char 0xf800))))) ; Kdown (= Kview)
(is (= :left (input/parse-key (str (char 0xf011))))) ; Kleft
(is (= :right (input/parse-key (str (char 0xf012)))))) ; Kright
(testing "the ANSI arrow escapes still resolve — this is additive"
(is (= :up (input/parse-key (str (char 27) "[A"))))
(is (= :down (input/parse-key (str (char 27) "[B"))))
(is (= :left (input/parse-key (str (char 27) "[D"))))
(is (= :right (input/parse-key (str (char 27) "[C"))))))
Loading