ci(tinygo): pin wasmtime and verify it landed on PATH - #685
Open
mparrett wants to merge 1 commit into
Open
Conversation
install.sh resolves "latest" by sed-ing tag_name out of an
unauthenticated GitHub API response. When that call is rate-limited the
sed yields a literal `{`, the download 404s, and the script still exits
0 — so the job stayed green through install and died two steps later at
`wasmtime run` with `command not found`, attributed to the reflect-shim
boot check. Pinning skips the API lookup entirely; the verify step makes
a bad install fail where it happens.
Closes #682
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Collaborator
|
Confirmed the mechanism rather than assuming it: Only nit: the version is a literal in the workflow, like the TinyGo pin above it, so a future |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tinygo-wasi-buildcould fail on a PR that touched nothing related to TinyGo, and blame the wrong step while doing it. #682 has the full trace; the short version is thatinstall.shresolves "latest" by sed-ingtag_nameout of an unauthenticated GitHub API response. When that call is rate-limited the sed yields a literal{, the download 404s, and the script still exits 0. The install step stayed green, and the job died two steps later atwasmtime runwithcommand not found— attributed toBoot past the reflect shim (must not trap), which reads as a real TinyGo regression.Two changes, both in the
tinygo-wasi-buildjob:--version v47.0.3sends the installer down its specific-version branch, which never calls the GitHub API, so the failure mode is gone rather than reported better. This also matchesInstall TinyGodirectly above, which has always pinned (v0.41.1).wasmtime --versionas its own step, sinceGITHUB_PATHonly affects later steps. A bad install now fails at the install, not two steps downstream.Verified the pinned path end to end: the installer takes
--versionand downloads that archive with no API call, and thev47.0.3linux asset the workflow fetches returns 200.v47.0.3 is current as of 2026-07-31. Pinning does mean someone bumps it eventually; that seems right for a job whose purpose is proving our TinyGo build boots past the reflect shim, not tracking wasmtime releases. If you want tip coverage it belongs in a scheduled job, not a per-PR gate that can go red on an unrelated PR.