Skip to content

fix(rt): resolve ns alias in LookupOrRegisterNSNoLoad #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nnunley wants to merge 1 commit into from
Closed

fix(rt): resolve ns alias in LookupOrRegisterNSNoLoad #627

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions pkg/rt/lang.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -686,6 +686,16 @@ func LookupOrRegisterNS(name string) *vm.Namespace {
}

func LookupOrRegisterNSNoLoad(name string) *vm.Namespace {
// Resolve the alias BEFORE touching the registry, as the loading callers do.
// Without this, LookupOrRegisterNSNoLoad("clojure.core") registers a DISTINCT
// "clojure.core" namespace instead of returning the canonical "core" — so the
// generated primitive registrar (RegisterGeneratedPrimitives, which calls this
// with "clojure.core"/"clojure.string"/…) Defs into the wrong namespace,
// invisible to core.lg's own bootstrap compile. Hand-registered primitives
// hid this by also Def'ing into the canonical ns via installLangNS; a primitive
// hoisted to //lg:native has ONLY the generated registration, so it must land
// in the canonical namespace to resolve.
name = resolveNSAlias(name)
nsMu.RLock()
e := nsRegistry[name]
nsMu.RUnlock()
Expand Down
Loading