Added restriction to limit the ID length to 255 characters in bucket lifecycle rules

[achouhan09]

Explain the changes

1. Currently, any length of ID can be accepted, as a fix we have added restriction to limit the length of ID to 255 characters only in bucket lifecycle rules.

Issues: Fixed #xxx / Gap #xxx

1. Fixed: NSFS | S3 | Lifecycle: Bucket lifecycle configuration accepts long rule ID #8549

Testing Instructions:

1. create s3 backingstore>bucketclass>obc
2. Apply below lifecycle configuration on the bucket created by obc:
   AWS_ACCESS_KEY_ID=<access-id> AWS_SECRET_ACCESS_KEY=<secret-key> aws s3api --no-verify-ssl --endpoint-url <endpoint-url> put-bucket-lifecycle-configuration --bucket <bucket-name> --lifecycle-configuration '{ "Rules": [ { "ID": "JiLekqcxZ6q0W0kKmiCLtVUYgyurIKmmUixcgHrkVKHyo6MfRU3EwPDD4NFBNWfA1Ej4qnuqSwS1NPRBvIn2x11aEf5kCK1GOjwp6SdTi17wivc9f7Zt44vaXkf73mME0PG1HwI8vGhzHfo9EptdWwdqG9J7mUYcGTbh63aUShPbjRAtLgIHYs2MyTTocohssHQ2cSnQiZjtLXi1j8h4AzFNFx5PzaPInmWqCiMrQPY6npbnbZrNKv7scXcLd0zkszxktHmgoPLLimJYHwaH0a2GRZqw6icnXUmSY4oXMzU1XAYBSJwQ3S3n42RlrVQK11JnZvKYYpKcB1cHz5oYNrGyRczopsgRvn6vPZ8TK9JfxTrDkwMB5o7vfQoXynZPkjeH4uX0N3TLqmEBUUcFGBPJND6vOMgfTiZDtMsBQPTtAepimZCbcRAmJ8F5GPj4ZQtjaXPgEFrEHWRpeEXknZBaBKZYaf8CQpi8WF3fHbnFbZK1G6x1oYG2gtn1MgHU", "Status": "enabled", "Filter": { "Prefix": "test/" }, "Expiration": { "Date": "2020-01-02T00:00:00.000Z" } } ] }'
3. Check for the similar error as aws, we should get an error for ID having length exeeding 255 characters.

• Tests added

[romayalon]

Hey @achouhan09

1. Can you please link to the Issues section the bug you are fixing?
2. Please add tests
3. Throwing InvalidArgument error code is based on the AWS S3 protocol?

[achouhan09]

Hi @romayalon
I think the InvalidArgument error code is suitable for this case as there is issue found in parameters passed. check this

Added issue link and tests. Thanks

[shirady]

Hi @romayalon I think the InvalidArgument error code is suitable for this case as there is issue found in parameters passed. check this

Could you test it in AWS and attach the results here?

[achouhan09]

Hi @romayalon I think the InvalidArgument error code is suitable for this case as there is issue found in parameters passed. check this

Could you test it in AWS and attach the results here?

[shirady]

replied to comment
@achouhan09 does noobaa use the same error message?
I mean this: "ID length should not exceed allowed limit of 255"

[achouhan09]

replied to comment @achouhan09 does noobaa use the same error message? I mean this: "ID length should not exceed allowed limit of 255"

For NooBaa, we will only get InvalidArgument error and no error msg on the command line. But we can check the error logs in the endpoint pod which is similar to what you are referring. Below is the NooBaa error:

An error occurred (InvalidArgument) when calling the PutBucketLifecycleConfiguration operation: Invalid Argument

[achouhan09]

replied to comment @achouhan09 does noobaa use the same error message? I mean this: "ID length should not exceed allowed limit of 255"

@shirady updated the error msg. Thanks

[shirady]

LGTM
(added a minor comment if you want to change)