Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bucket Notifications - doc #8557

Merged
merged 1 commit into from
Mar 11, 2025
Merged

Bucket Notifications - doc #8557

merged 1 commit into from
Mar 11, 2025

Conversation

alphaprinz
Copy link
Contributor

Explain the changes

  1. Add documentation for the bucket notification feature.
  • Doc added/updated
  • Tests added

@nimrod-becker
Copy link
Contributor

Might be worth adding

  1. Scope if what is supported, what isn't (which events, which filters etc.)
  2. A little bit about how the magic works (persistent logger, to a filesystem, then consumed by a worker)
  3. How do we handle failures in the different places, when do we retry when do we give up

@alphaprinz alphaprinz marked this pull request as draft December 6, 2024 19:11
@alphaprinz
Copy link
Contributor Author

I'm demoting to draft until new PR notes are pushed and docs are updated accordingly.

@alphaprinz alphaprinz force-pushed the notif_doc branch 4 times, most recently from 65efbc5 to 6803a24 Compare December 19, 2024 16:43
@pull-request-size pull-request-size bot added size/L and removed size/M labels Dec 19, 2024
@alphaprinz alphaprinz marked this pull request as ready for review December 24, 2024 05:30
@alphaprinz alphaprinz force-pushed the notif_doc branch 2 times, most recently from d4d4b08 to 2dd5c19 Compare December 24, 2024 06:06
@nimrod-becker
Copy link
Contributor

@alphaprinz what is missing here?

@alphaprinz
Copy link
Contributor Author

@nimrod-becker This has been ready for merge for quite some time.
I've started a rebase so we can merge (unless someone wants edits).
Don't forget there's also PR for operator noobaa/noobaa-operator#1480

@alphaprinz
Bucket Notifications - doc
9d2bfde 
Signed-off-by: Amit Prinz Setter <[email protected]>
@alphaprinz alphaprinz merged commit 5395918 into noobaa:master Mar 11, 2025
11 checks passed
alphaprinz added a commit to alphaprinz/noobaa-core that referenced this pull request Mar 12, 2025
@alphaprinz
Bucket Notifications - doc (noobaa#8557)
af7fd4d 
Signed-off-by: Amit Prinz Setter <[email protected]>
@alphaprinz alphaprinz mentioned this pull request Mar 12, 2025
Merged
alphaprinz added a commit to alphaprinz/noobaa-core that referenced this pull request Mar 13, 2025
@alphaprinz
Bucket Notifications - doc (noobaa#8557)
83ae9f8 
Signed-off-by: Amit Prinz Setter <[email protected]>
alphaprinz added a commit to alphaprinz/noobaa-core that referenced this pull request Mar 24, 2025
@alphaprinz
Bucket Notifications - doc (noobaa#8557)
f5598ed 
Signed-off-by: Amit Prinz Setter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nimrod-becker nimrod-becker nimrod-becker approved these changes

@guymguym guymguym Awaiting requested review from guymguym

@dannyzaken dannyzaken Awaiting requested review from dannyzaken

@liranmauda liranmauda Awaiting requested review from liranmauda

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alphaprinz @nimrod-becker