PR1 - To install and upgrade noobaa version for running the tests #8517
Conversation
achouhan09
force-pushed
the
upgrade-tests
branch
8 times, most recently
from
1032b01 to
15a23fc
Compare
achouhan09
force-pushed
the
upgrade-tests
branch
from
15a23fc to
3f4cf92
Compare
achouhan09
changed the title
achouhan09
force-pushed
the
upgrade-tests
branch
from
3f4cf92 to
8515ca8
Compare
achouhan09
force-pushed
the
upgrade-tests
branch
from
8515ca8 to
e496520
Compare
achouhan09
force-pushed
the
upgrade-tests
branch
from
e496520 to
fc33e4d
Compare
achouhan09
force-pushed
the
upgrade-tests
branch
from
fc33e4d to
e762822
Compare
achouhan09
force-pushed
the
upgrade-tests
branch
from
e762822 to
f6b0289
Compare
achouhan09
force-pushed
the
upgrade-tests
branch
4 times, most recently
from
9fcd6af to
7808b68
Compare
| - name: Build noobaa (latest) | ||
| run: | | ||
| cd ./noobaa-core | ||
| make noobaa NOOBAA_TAG=noobaa-core:upgrade-tests |
There was a problem hiding this comment.
If we are on master branch, then the image of noobaa-core:master and noobaa-core:upgrade-tests are the same? (maybe I missed something - why should we continue with the job?)
There was a problem hiding this comment.
Here, the flow is like in step 1 we are building noobaa core from master/input branch for installation of noobaa and in step 4 we are building noobaa core using PR code to upgrade the noobaa.
| --db-resources='{ "limits": {"cpu": "200m","memory": "2G"}, "requests": {"cpu": "200m","memory": "2G"}}' \ | ||
| --core-resources='{ "limits": {"cpu": "200m","memory": "1G"}, "requests": {"cpu": "200m","memory": "1G"}}' \ | ||
| --endpoint-resources='{ "limits": {"cpu": "200m","memory": "1G"}, "requests": {"cpu": "200m","memory": "1G"}}' \ | ||
| --noobaa-image='noobaa-core:${{ env.BRANCH_NAME || 'master' }}' |
There was a problem hiding this comment.
In the step you wrote: "Install noobaa system (from master)" - did you mean master in the core repo, right? Then why --noobaa-image='noobaa-core:${{ env.BRANCH_NAME || 'master' }}'? I think it should be noobaa-core:upgrade-tests (which according to the steps represents "Build noobaa (latest)".
Are you sure the system should be installed in the latest version?
There was a problem hiding this comment.
I have also added pull request referece in latest build (in step 4) in my last commit, it would work I think.
.github/workflows/upgrade-tests.yaml
Outdated
| - name: Upgrade noobaa to latest | ||
| run: | | ||
| cd ./noobaa-operator | ||
| VERSION=$(go run cmd/version/main.go) |
There was a problem hiding this comment.
I'm suggesting to add that it is the operator repo version, so it won't be confusing.
| VERSION=$(go run cmd/version/main.go) | |
| OPERATOR_VERSION=$(go run cmd/version/main.go) |
.github/workflows/upgrade-tests.yaml
Outdated
| run: | | ||
| cd ./noobaa-operator | ||
| VERSION=$(go run cmd/version/main.go) | ||
| ./build/_output/bin/noobaa-operator upgrade --noobaa-image='noobaa-core:upgrade-tests' --operator-image='noobaa/noobaa-operator:$VERSION' |
There was a problem hiding this comment.
In case you would accept the suggestion then it needs to be changed also here:
| ./build/_output/bin/noobaa-operator upgrade --noobaa-image='noobaa-core:upgrade-tests' --operator-image='noobaa/noobaa-operator:$VERSION' | |
| ./build/_output/bin/noobaa-operator upgrade --noobaa-image='noobaa-core:upgrade-tests' --operator-image='noobaa/noobaa-operator:$OPERATOR_VERSION' |
Signed-off-by: Aayush Chouhan <[email protected]>
Signed-off-by: Aayush Chouhan <[email protected]>
Signed-off-by: Aayush Chouhan <[email protected]>
achouhan09
force-pushed
the
upgrade-tests
branch
from
7808b68 to
ddd44ab
Compare
Signed-off-by: Aayush Chouhan <[email protected]>
achouhan09
force-pushed
the
upgrade-tests
branch
from
ddd44ab to
5719ee6
Compare
Explain the changes
Testing Instructions: