-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NC | Online Upgrade | RPM spec changes and github action for RPM install test #8516
Open
romayalon
wants to merge
10
commits into
noobaa:master
Choose a base branch
from
romayalon:romy-online-upgrade-rpm
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16c6232
to
a237086
Compare
14619b3
to
156d2e6
Compare
Signed-off-by: Romy <[email protected]>
Signed-off-by: Romy <[email protected]>
Signed-off-by: Romy <[email protected]>
Signed-off-by: Romy <[email protected]>
Signed-off-by: Romy <[email protected]>
4d27cfd
to
e93b811
Compare
Signed-off-by: Romy <[email protected]>
Signed-off-by: Romy <[email protected]>
Signed-off-by: Romy <[email protected]>
Signed-off-by: Romy <[email protected]>
Signed-off-by: Romy <[email protected]>
This PR had no activity for too long - it will now be labeled stale. Update it to prevent it from getting closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
/usr/local/noobaa-core
automatically, we first -a. copy the new source code to
/usr/local/.noobaa-core-{new_version}/
hidden directoryb. on the post section -
i. move current version source code from
/usr/local/noobaa-core/
to/usr/local/.noobaa-core-{current_version}/
ii. move new version source code from
/usr/local/.noobaa-core-{new_version}/
to/usr/local/noobaa-core/
This way we can ensure, untracked files added to the old noobaa-core source code dir are removed.
Issues: Fixed #xxx / Gap #xxx
Testing Instructions:
docker run --privileged --user root -d --platform=linux/amd64 oowy/redhat:ubi9
docker exec -it {container_id} bash
yum install wget
wget https://noobaa-core-rpms.s3.us-east-1.amazonaws.com/noobaa-core-5.16.0-20240403.el9.x86_64.rpm
rpm -i noobaa-core-5.16.0-20240403.el9.x86_64.rpm
mkdir /usr/local/noobaa-core/user-modified-dir/
echo "blblblalal" > /usr/local/noobaa-core/user_modified_dir/user_modified_file
wget https://noobaa-core-rpms.s3.us-east-1.amazonaws.com/${rpm having this PR changes}
rpm -Uvh {rpm having this PR changes}
and user_modified_dir/.