Skip to content

Mostly fix Python 3.13 #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 11, 2025
Merged

Mostly fix Python 3.13 #199

merged 2 commits into from
Apr 11, 2025

Conversation

Margen67
Copy link
Contributor

Marked as a draft since onnx 1.18 is currently a prerelease and the build fails on Windows for some reason.
Related: #174

@beveradb
Copy link
Collaborator

Thanks! I'll merge anyway for now and either fix or exclude that windows+3.13 combo.
It sounds like it'll probably be resolved by updating Numpy; numpy/numpy#27894

@beveradb beveradb marked this pull request as ready for review April 11, 2025 01:48
@beveradb beveradb merged commit 7354121 into nomadkaraoke:main Apr 11, 2025
11 of 12 checks passed
@Margen67 Margen67 deleted the python_313 branch April 11, 2025 03:54
@beveradb
Copy link
Collaborator

audio-separator version 0.31 is now released and should work on all platforms with all supported python versions including 3.13 🙏

FYI, I ended up having to fork onnx2torch (https://pypi.org/project/onnx2torch-py313/) to change it to require onnx-weekly instead of onnx for now as otherwise the transitive dependency forced pip to try/fail to build onnx 1.17 on python 3.13 which doesn't work.
Once ONNX 1.18 is fully released and there are wheels for Python 3.13 available on PyPI, I'll delete my onnx2torch-py313 fork/published package and revert audio-separator to using the regular onnx2torch package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants