-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Parser and formatter support for enum
s
#7110
Conversation
Compilation Report
|
Execution Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Compilation Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.10
.
Benchmark suite | Current: 6ebbec6 | Previous: 82cb900 | Ratio |
---|---|---|---|
rollup-base-public |
30.94 s |
27.64 s |
1.12 |
private-kernel-inner |
2.236 s |
2.002 s |
1.12 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
Execution Memory Report
|
Compilation Memory Report
|
Does seem like a large difference for a PR which shouldn't impact anything |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's happening! 🤩
Hm, seeing that huge difference, maybe allowing Just kidding, there's probably something wrong in CI? The compilation time change would also be explained by that. |
Globals brought a +2 overhead to all programs without globals. Probably just need to sync with master, as programs with globals would regress. |
Description
Problem*
Step towards #988
Summary*
Adds parser & formatter support for enumerations. Elaboration & comptime support is left as a
todo!()
.Additional Context
Enums are currently gated behind an experimental feature:
Although they're behind a
todo!()
, it won't panic the compiler since they're elaborated to begin with.Documentation*
Check one:
PR Checklist*
cargo fmt
on default settings.