chore: add regression test for #6530 #7089

michaeljklein · 2025-01-16T14:40:00Z

Description

Problem*

Resolves #6530, probably fixed by #7041

Summary*

Additional Context

Documentation*

Check one:

No documentation needed.
Documentation included in this PR.
[For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

I have tested the changes locally.
I have formatted the changes with Prettier and/or cargo fmt on default settings.

github-actions · 2025-01-16T14:47:37Z

Execution Report

Program	Execution Time	%
sha256_regression	0.051s	0%
regression_4709	0.001s	0%
ram_blowup_regression	0.599s	-2%
rollup-root	0.104s	0%
rollup-merge	0.006s	-15%
rollup-block-root	36.900s	1%
rollup-block-merge	0.105s	0%
rollup-base-public	1.224s	1%
rollup-base-private	0.453s	0%
private-kernel-tail	0.019s	0%
private-kernel-reset	0.312s	0%
private-kernel-inner	0.069s	1%

github-actions · 2025-01-16T14:47:58Z

Compilation Report

Program	Compilation Time	%
sha256_regression	1.020s	-12%
regression_4709	0.813s	-15%
ram_blowup_regression	16.300s	-2%
rollup-root	3.454s	-2%
rollup-merge	1.976s	-8%
rollup-block-root-single-tx	137.000s	-1%
rollup-block-root-empty	2.050s	-2%
rollup-block-root	146.000s	5%
rollup-block-merge	3.594s	1%
rollup-base-public	28.040s	0%
rollup-base-private	10.340s	-2%
private-kernel-tail	0.995s	2%
private-kernel-reset	6.354s	-2%
private-kernel-inner	2.012s	-2%

jfecher

Can this be a frontend test instead? I think we'd just need to define the Into trait

github-actions · 2025-01-16T14:54:41Z

Execution Memory Report

Program	Peak Memory
keccak256	74.71M
workspace	123.88M
regression_4709	316.02M
ram_blowup_regression	512.62M
rollup-root	498.39M
rollup-merge	473.13M
rollup-block-root	1.22G
rollup-block-merge	498.40M
rollup-base-public	733.92M
rollup-base-private	590.58M
private-kernel-tail	180.71M
private-kernel-reset	245.32M
private-kernel-inner	208.72M

github-actions · 2025-01-16T14:54:44Z

Compilation Memory Report

Program	Peak Memory
keccak256	77.65M
workspace	123.71M
regression_4709	424.15M
ram_blowup_regression	1.46G
rollup-root	601.04M
rollup-merge	494.01M
rollup-block-root-single-tx	16.06G
rollup-block-root-empty	488.18M
rollup-block-root	16.07G
rollup-block-merge	601.03M
rollup-base-public	2.38G
rollup-base-private	1.14G
private-kernel-tail	207.27M
private-kernel-reset	584.29M
private-kernel-inner	294.48M

michaeljklein · 2025-01-16T14:57:50Z

@jfecher I'll give it a shot 👍

feat: add `ConstrainNotEqual` instruction (noir-lang/noir#7032) feat!: `loop` statements (only frontend) (noir-lang/noir#7092) fix!: Include kind in `StructDefinition::generics` and fix derivation of Eq in structs with numeric generics (noir-lang/noir#7076) chore: add test for isuee #7090 (noir-lang/noir#7091) chore: mark `noir-edwards` as expected to compile (noir-lang/noir#7085) chore: allow passing custom conditions to inlining pass (noir-lang/noir#7083) feat(LSP): auto-import trait reexport if trait is not visible (noir-lang/noir#7079) fix: Allow implicit associated types on integer type kinds (noir-lang/noir#7078) feat(ssa): Treat globals as constant in a function's DFG (noir-lang/noir#7040) chore: Do not make new instruction if it hasn't changed (noir-lang/noir#7069) fix: do not remove memory blocks used as brillig input (noir-lang/noir#7073)

Automated pull of development from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE chore: add regression test for #6530 (noir-lang/noir#7089) feat: add `ConstrainNotEqual` instruction (noir-lang/noir#7032) feat!: `loop` statements (only frontend) (noir-lang/noir#7092) fix!: Include kind in `StructDefinition::generics` and fix derivation of Eq in structs with numeric generics (noir-lang/noir#7076) chore: add test for isuee #7090 (noir-lang/noir#7091) chore: mark `noir-edwards` as expected to compile (noir-lang/noir#7085) chore: allow passing custom conditions to inlining pass (noir-lang/noir#7083) feat(LSP): auto-import trait reexport if trait is not visible (noir-lang/noir#7079) fix: Allow implicit associated types on integer type kinds (noir-lang/noir#7078) feat(ssa): Treat globals as constant in a function's DFG (noir-lang/noir#7040) chore: Do not make new instruction if it hasn't changed (noir-lang/noir#7069) fix: do not remove memory blocks used as brillig input (noir-lang/noir#7073) END_COMMIT_OVERRIDE --------- Co-authored-by: Tom French <[email protected]>

@safety

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.71.0</summary> ## [0.71.0](aztec-package-v0.70.0...aztec-package-v0.71.0) (2025-01-17) ### Features * Track block building helpers ([#11190](#11190)) ([a749dc1](a749dc1)), closes [#11184](#11184) </details> <details><summary>barretenberg.js: 0.71.0</summary> ## [0.71.0](barretenberg.js-v0.70.0...barretenberg.js-v0.71.0) (2025-01-17) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-packages: 0.71.0</summary> ## [0.71.0](aztec-packages-v0.70.0...aztec-packages-v0.71.0) (2025-01-17) ### ⚠ BREAKING CHANGES * `loop` statements (only frontend) (noir-lang/noir#7092) * Include kind in `StructDefinition::generics` and fix derivation of Eq in structs with numeric generics (noir-lang/noir#7076) * Attestation collection times out based on sequencer timetable ([#11248](#11248)) ### Features * `loop` statements (only frontend) (noir-lang/noir#7092) ([a964cd0](a964cd0)) * Add `ConstrainNotEqual` instruction (noir-lang/noir#7032) ([a964cd0](a964cd0)) * Archive public testnet tx data ([#11192](#11192)) ([66f2014](66f2014)) * Backup proof failures to google cloud storage ([#11255](#11255)) ([b4775fd](b4775fd)), closes [#11062](#11062) * **docs:** Algolia->typesense ([#11034](#11034)) ([d254f49](d254f49)) * Improve PXE contract DB capabilities ([#11303](#11303)) ([fab5570](fab5570)) * **LSP:** Auto-import trait reexport if trait is not visible (noir-lang/noir#7079) ([a964cd0](a964cd0)) * Process note logs in aztec-nr ([#10651](#10651)) ([708139d](708139d)) * Reenable constrained config for roots ([#10605](#10605)) ([a6ebc2e](a6ebc2e)) * **spartan:** Add extra accounts ([#11300](#11300)) ([7782836](7782836)) * **ssa:** Treat globals as constant in a function's DFG (noir-lang/noir#7040) ([a964cd0](a964cd0)) * Track block building helpers ([#11190](#11190)) ([a749dc1](a749dc1)), closes [#11184](#11184) ### Bug Fixes * Allow implicit associated types on integer type kinds (noir-lang/noir#7078) ([a964cd0](a964cd0)) * Do not remove memory blocks used as brillig input (noir-lang/noir#7073) ([a964cd0](a964cd0)) * Ensure 'docker info' works before preceding ([#11286](#11286)) ([0b0e81a](0b0e81a)) * Fail in proxy deployment should fail the step ([#11308](#11308)) ([b780d75](b780d75)) * Faster polling times for archiver and sequencer ([#11262](#11262)) ([d70511e](d70511e)) * Https://github.com/AztecProtocol/aztec-packages/issues/8939 ([66f2014](66f2014)) * Idempotent deploy-l1-contracts with initial validators ([#11284](#11284)) ([3a3f9c0](3a3f9c0)), closes [#11283](#11283) * Include kind in `StructDefinition::generics` and fix derivation of Eq in structs with numeric generics (noir-lang/noir#7076) ([a964cd0](a964cd0)) * Legacy runner start ([#11291](#11291)) ([0b2a619](0b2a619)) * Reallocate commitment key to avoid pippenger error ([#11249](#11249)) ([8fc2011](8fc2011)) * References to a3 in docs ([#11256](#11256)) ([caf88fa](caf88fa)) * Remove bb path override in cli-wallet ([#11280](#11280)) ([a6a226e](a6a226e)) * Resolve misc bugs handling phases in avm witgen ([#11218](#11218)) ([29bc4bd](29bc4bd)) * Sequencer timetable accounts for spare time ([#11221](#11221)) ([f1b9211](f1b9211)) * Validator ignores block limits during reexec ([#11288](#11288)) ([920a521](920a521)) ### Miscellaneous * Add circuit input checks to bootstrap.sh ([#11261](#11261)) ([a718b15](a718b15)) * Add regression test for [#6530](#6530) (noir-lang/noir#7089) ([a964cd0](a964cd0)) * Add test for isuee [#7090](#7090) (noir-lang/noir#7091) ([a964cd0](a964cd0)) * Allow passing custom conditions to inlining pass (noir-lang/noir#7083) ([a964cd0](a964cd0)) * Attestation collection times out based on sequencer timetable ([#11248](#11248)) ([946a418](946a418)) * **avm:** Calldata, returndata slices out of range padded with zeros ([#11265](#11265)) ([a469c94](a469c94)), closes [#10933](#10933) * Delete external-ci-approved.yml ([#11258](#11258)) ([642bce6](642bce6)) * Demote error closing forks to warn ([#11263](#11263)) ([a5b7a6a](a5b7a6a)) * Do not make new instruction if it hasn't changed (noir-lang/noir#7069) ([a964cd0](a964cd0)) * Ensure devnet has unproven config ([#11302](#11302)) ([085f782](085f782)) * Fixing `[@safety](https://github.com/safety)` warnings ([#11094](#11094)) ([5de24e0](5de24e0)) * Log correlation in traces in google cloud ([#11276](#11276)) ([fbcc8ef](fbcc8ef)), closes [#11019](#11019) [#10937](#10937) * Mark `noir-edwards` as expected to compile (noir-lang/noir#7085) ([a964cd0](a964cd0)) * Move shared pcs functionality to internal library in solidity and small refactorings in sumcheck ([#11230](#11230)) ([507ae9d](507ae9d)) * Reduce the number of provers in rc-1 ([#11296](#11296)) ([92e40ff](92e40ff)) * Remove references to padding txs ([#11264](#11264)) ([32408f6](32408f6)) * Remove warnings from types and rollup lib crates ([#11269](#11269)) ([9f389a7](9f389a7)) * Replace relative paths to noir-protocol-circuits ([8ece166](8ece166)) * Replace relative paths to noir-protocol-circuits ([be42305](be42305)) * Retry deploys ([#11252](#11252)) ([23cfbb4](23cfbb4)) * Set failed proof store for spartan deployments ([#11282](#11282)) ([f787a52](f787a52)) * Silence "Updated proven chain" log ([#11250](#11250)) ([44bd79b](44bd79b)) * Silence circuit return values in CI ([#11259](#11259)) ([db3d860](db3d860)) * Stable masternet images ([#11289](#11289)) ([07fabe8](07fabe8)) </details> <details><summary>barretenberg: 0.71.0</summary> ## [0.71.0](barretenberg-v0.70.0...barretenberg-v0.71.0) (2025-01-17) ### Bug Fixes * Reallocate commitment key to avoid pippenger error ([#11249](#11249)) ([8fc2011](8fc2011)) * Resolve misc bugs handling phases in avm witgen ([#11218](#11218)) ([29bc4bd](29bc4bd)) ### Miscellaneous * **avm:** Calldata, returndata slices out of range padded with zeros ([#11265](#11265)) ([a469c94](a469c94)), closes [#10933](#10933) * Move shared pcs functionality to internal library in solidity and small refactorings in sumcheck ([#11230](#11230)) ([507ae9d](507ae9d)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

michaeljklein and others added 3 commits January 16, 2025 09:38

add regression test for #6530

624e3d5

nargo fmt

4a96d64

Merge branch 'master' into michaeljklein/regression-test-6530

78a72fa

jfecher reviewed Jan 16, 2025

View reviewed changes

michaeljklein marked this pull request as draft January 16, 2025 15:00

michaeljklein and others added 2 commits January 16, 2025 11:13

move compile-success test to a frontend test

aa7fea8

Merge branch 'master' into michaeljklein/regression-test-6530

bbeaa9f

jfecher approved these changes Jan 16, 2025

View reviewed changes

cargo fmt

ba78ad0

TomAFrench approved these changes Jan 16, 2025

View reviewed changes

michaeljklein marked this pull request as ready for review January 16, 2025 18:31

Merge branch 'master' into michaeljklein/regression-test-6530

29d9eaa

michaeljklein enabled auto-merge January 16, 2025 18:31

michaeljklein added this pull request to the merge queue Jan 16, 2025

auto-merge was automatically disabled January 16, 2025 18:48
Pull Request is not mergeable

Merged via the queue into master with commit c172880 Jan 16, 2025
99 checks passed

michaeljklein deleted the michaeljklein/regression-test-6530 branch January 16, 2025 18:50

AztecBot mentioned this pull request Jan 16, 2025

feat: Sync from noir AztecProtocol/aztec-packages#11246

Closed

AztecBot mentioned this pull request Jan 16, 2025

feat: Sync from noir AztecProtocol/aztec-packages#11279

Merged

AztecBot mentioned this pull request Jan 17, 2025

chore(master): Release 0.71.0 AztecProtocol/aztec-packages#11247

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: add regression test for #6530 #7089

chore: add regression test for #6530 #7089

michaeljklein commented Jan 16, 2025

github-actions bot commented Jan 16, 2025 •

edited

Loading

github-actions bot commented Jan 16, 2025 •

edited

Loading

jfecher left a comment

github-actions bot commented Jan 16, 2025 •

edited

Loading

github-actions bot commented Jan 16, 2025 •

edited

Loading

michaeljklein commented Jan 16, 2025

chore: add regression test for #6530 #7089

chore: add regression test for #6530 #7089

Conversation

michaeljklein commented Jan 16, 2025

Description

Problem*

Summary*

Additional Context

Documentation*

PR Checklist*

github-actions bot commented Jan 16, 2025 • edited Loading

Execution Report

github-actions bot commented Jan 16, 2025 • edited Loading

Compilation Report

jfecher left a comment

Choose a reason for hiding this comment

github-actions bot commented Jan 16, 2025 • edited Loading

Execution Memory Report

github-actions bot commented Jan 16, 2025 • edited Loading

Compilation Memory Report

michaeljklein commented Jan 16, 2025

github-actions bot commented Jan 16, 2025 •

edited

Loading

github-actions bot commented Jan 16, 2025 •

edited

Loading

github-actions bot commented Jan 16, 2025 •

edited

Loading

github-actions bot commented Jan 16, 2025 •

edited

Loading