feat(ssa): Globals DIE #7081
Merged
feat(ssa): Globals DIE #7081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vezenovm
commented
Jan 15, 2025
Changes to Brillig bytecode sizes
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
Changes to number of Brillig opcodes executed
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
5 tasks
Execution Report
|
Compilation Report
|
Compilation Memory Report
|
Execution Memory Report
|
aakoshh
reviewed
Jan 16, 2025
| pub(crate) fn dead_instruction_elimination( | ||
| &mut self, | ||
| insert_out_of_bounds_checks: bool, | ||
| ) -> HashSet<ValueId> { |
There was a problem hiding this comment.
Can you add some explanation to the docstrings about the new return value? Are the globals the only reasonable thing to return here?
There was a problem hiding this comment.
I will add some comments. We do not need anything but the used globals as all other values are going to be per function.
aakoshh
reviewed
Jan 16, 2025
TomAFrench
reviewed
Jan 16, 2025
TomAFrench
reviewed
Jan 16, 2025
|
Generally looks good to me, some nits. I think it's worth merging this into the other SSA globals PR due to the compilation speed regressions in there that are solved by this one |
Yeah agreed. I will wait for all comments to be resolved before merging into #7021 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves #7021 (comment)
Summary*
DIE for globals is a little bit more funky as we do not have a mutable instructions vector as part of a block. We could do this but I would like to move away from re-using the entire Function/DataFlowGraph construct for globals which are much simpler than our functions.
We also want to account for numeric constants among our unused globals as declaring them in Brillig gen comes with a cost. Our current DIE only looks at instruction results, but we want to look at both instruction results and values representing constants.
Additional Context
I don't expect this PR to fully revert the regressions we see in #7021 due to the overhead for the global initialization call/return.
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.