-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ssa): Expand feature set of the Brillig constraint check #7060
Open
rkarabut
wants to merge
9
commits into
master
Choose a base branch
from
rk/brillig-check-fixes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+628
−318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Execution Memory Report
|
Compilation Memory Report
|
Compilation Report
|
Execution Report
|
Indeed, would have to look into it |
michaeljklein
requested changes
Jan 15, 2025
compiler/noirc_evaluator/src/ssa/checks/check_for_underconstrained_values.rs
Show resolved
Hide resolved
compiler/noirc_evaluator/src/ssa/checks/check_for_underconstrained_values.rs
Outdated
Show resolved
Hide resolved
compiler/noirc_evaluator/src/ssa/checks/check_for_underconstrained_values.rs
Show resolved
Hide resolved
compiler/noirc_evaluator/src/ssa/checks/check_for_underconstrained_values.rs
Show resolved
Hide resolved
Should be all of them |
…ined_values.rs Co-authored-by: Michael J Klein <[email protected]>
…xes' into rk/brillig-check-fixes
This was
linked to
issues
Jan 15, 2025
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves a number of issues that came up in the initial introduction of the Brillig constraint check, expanding its feature set.
Problem
#6698, #6706, #6713, #6735
Summary
Resolves #6698 by creating and maintaining additional tainted value sets for every result array element, #6713 by tracking EnableSideEffectsIf condition values, and #6735 along with #6706 by introducing a quick pass gathering information on Brillig calls. New tests for every issue are included.
As fixing #6698 makes the
check_underconstrained_regression
test program (correctly) issue a bug warning now, the program has been updated to properly constrain the involved array elements.Additional Context
Documentation
Check one:
PR Checklist*
cargo fmt
on default settings.