Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Test Brillig report with inliner settings #7052

Conversation

vezenovm
Copy link
Contributor

Description

Problem*

Resolves

Summary*

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

Copy link
Contributor

github-actions bot commented Jan 13, 2025

Changes to number of Brillig opcodes executed

Generated at commit: 5d9957730fc3e4e35179332763ac9b34cb85188f, compared to commit: 3b7ac26ab8ff8aed27dcdb3b2e43bd36e035b9ca

🧾 Summary (10% most significant diffs)

Program Brillig opcodes (+/-) %
global_var_regression_simple_inliner_zero +255 ❌ +157.41%
regression_4709_inliner_min +1,064,099 ❌ +100.00%

Full diff report 👇
Program Brillig opcodes (+/-) %
global_var_regression_simple_inliner_zero 417 (+255) +157.41%
regression_4709_inliner_min 2,128,203 (+1,064,099) +100.00%
global_var_regression_simple_inliner_min 721 (+358) +98.62%
regression_4709_inliner_zero 1,992,838 (+928,810) +87.29%

Copy link
Contributor

github-actions bot commented Jan 14, 2025

Changes to circuit sizes

Generated at commit: 5d9957730fc3e4e35179332763ac9b34cb85188f, compared to commit: 3b7ac26ab8ff8aed27dcdb3b2e43bd36e035b9ca

🧾 Summary (10% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
global_var_regression_simple +122 ❌ +93.85% +306 ❌ +9.97%
regression_4709 +61 ❌ +88.41% +152 ❌ +5.21%

Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
global_var_regression_simple 252 (+122) +93.85% 3,374 (+306) +9.97%
regression_4709 130 (+61) +88.41% 3,068 (+152) +5.21%

Copy link
Contributor

github-actions bot commented Jan 14, 2025

Execution Memory Report

Program Peak Memory
keccak256 74.67M
workspace 123.94M
regression_4709 316.07M
ram_blowup_regression 512.61M
rollup-base-public 478.87M
rollup-base-private 325.48M
private-kernel-tail 180.47M
private-kernel-reset 245.16M
private-kernel-inner 208.55M

Copy link
Contributor

github-actions bot commented Jan 14, 2025

Compilation Memory Report

Program Peak Memory %
keccak256 78.13M 0%
workspace 123.88M 0%
regression_4709 539.92M 27%
ram_blowup_regression 1.58G 0%
rollup-base-public 4.85G 0%
rollup-base-private 1.26G 0%
private-kernel-tail 207.18M 0%
private-kernel-reset 669.26M 0%
private-kernel-inner 294.40M 0%

Copy link
Contributor

github-actions bot commented Jan 14, 2025

Execution Report

Program Execution Time %
sha256_regression 0.052s 0%
regression_4709 0.001s 0%
ram_blowup_regression 0.598s -2%
rollup-root 0.104s 0%
rollup-merge 0.007s 16%
rollup-block-merge 0.104s 0%
rollup-base-public 1.228s -1%
rollup-base-private 0.451s 0%
private-kernel-tail 0.019s 0%
private-kernel-reset 0.311s 0%
private-kernel-inner 0.068s -2%

Copy link
Contributor

github-actions bot commented Jan 14, 2025

Compilation Report

Program Compilation Time %
sha256_regression 1.240s -8%
regression_4709 1.270s 51%
ram_blowup_regression 17.000s -2%
rollup-root 3.468s 1%
rollup-merge 1.808s -1%
rollup-block-merge 3.316s -3%
rollup-base-public 39.340s -3%
rollup-base-private 12.480s 2%
private-kernel-tail 0.939s -10%
private-kernel-reset 6.276s -3%
private-kernel-inner 2.030s 1%

Copy link
Contributor

github-actions bot commented Jan 14, 2025

Changes to Brillig bytecode sizes

Generated at commit: 5d9957730fc3e4e35179332763ac9b34cb85188f, compared to commit: 3b7ac26ab8ff8aed27dcdb3b2e43bd36e035b9ca

🧾 Summary (10% most significant diffs)

Program Brillig opcodes (+/-) %
regression_4709_inliner_min +133,721 ❌ +99.94%
global_var_regression_simple_inliner_zero +61 ❌ +47.29%

Full diff report 👇
Program Brillig opcodes (+/-) %
regression_4709_inliner_min 267,527 (+133,721) +99.94%
global_var_regression_simple_inliner_zero 190 (+61) +47.29%
global_var_regression_simple_inliner_min 275 (+14) +5.36%
regression_4709_inliner_zero 133,770 (+42) +0.03%

@vezenovm
Copy link
Contributor Author

The reports are showing what I expected so I am closing

@vezenovm vezenovm closed this Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant