Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow deduplicating Truncate and Not instructions #7010

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: allow deduplicating Truncate and Not instructions #7010

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f68fb4
feat: allow deduplicating `Truncate` and `Not` instructions
TomAFrench Jan 9, 2025
0165d34
Merge branch 'master' into tf/more-deduplication
TomAFrench Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions compiler/noirc_evaluator/src/ssa/ir/instruction.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,7 +407,7 @@
// These can fail.
Constrain(..) | RangeCheck { .. } => true,

// This should never be side-effectful

Check warning on line 410 in compiler/noirc_evaluator/src/ssa/ir/instruction.rs

View workflow job for this annotation

GitHub Actions / Code 

Unknown word (effectful)
MakeArray { .. } | Noop => false,

// Some binary math can overflow or underflow
Expand Down Expand Up @@ -473,8 +473,8 @@
// removed entirely.
Noop => true,

// Cast instructions can always be deduplicated
Cast(_, _) => true,
// These instructions can always be deduplicated
Cast(_, _) | Truncate { .. } | Not(_) => true,

// Arrays can be mutated in unconstrained code so code that handles this case must
// take care to track whether the array was possibly mutated or not before
Expand All @@ -486,12 +486,7 @@
// Replacing them with a similar instruction potentially enables replacing an instruction
// with one that was disabled. See
// https://github.com/noir-lang/noir/pull/4716#issuecomment-2047846328.
Binary(_)
| Not(_)
| Truncate { .. }
| IfElse { .. }
| ArrayGet { .. }
| ArraySet { .. } => {
Binary(_) | IfElse { .. } | ArrayGet { .. } | ArraySet { .. } => {
deduplicate_with_predicate || !self.requires_acir_gen_predicate(&function.dfg)
}
}
Expand Down
Loading