Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add compile-time assertions on generic arguments of stdlib functions #6981

Open
wants to merge 25 commits into
base: master
Choose a base branch
from

Conversation

michaeljklein
Copy link
Contributor

Description

Problem*

Resolves #6962

Summary*

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@michaeljklein michaeljklein changed the title Add compile-time assertions on generic arguments of stdlib functions chore: add compile-time assertions on generic arguments of stdlib functions Jan 7, 2025
Copy link
Contributor

github-actions bot commented Jan 7, 2025

Compilation Report

Program Compilation Time %
sha256_regression 1.050s 2%
regression_4709 0.819s 4%
ram_blowup_regression 16.300s 0%
rollup-root 3.490s -5%
rollup-merge 2.034s -4%
rollup-block-root-single-tx 137.000s -7%
rollup-block-root-empty 2.138s -5%
rollup-block-root 136.000s -5%
rollup-block-merge 3.608s 3%
rollup-base-public 28.040s -4%
rollup-base-private 11.960s 19%
private-kernel-tail 0.988s -2%
private-kernel-reset 6.242s 3%
private-kernel-inner 2.098s -6%

Copy link
Contributor

github-actions bot commented Jan 7, 2025

Execution Report

Program Execution Time %
sha256_regression 0.051s 1%
regression_4709 0.001s 0%
ram_blowup_regression 0.600s 1%
rollup-root 0.104s -1%
rollup-merge 0.006s 0%
rollup-block-root 37.000s 0%
rollup-block-merge 0.105s 0%
rollup-base-public 1.224s -1%
rollup-base-private 0.454s 1%
private-kernel-tail 0.019s -10%
private-kernel-reset 0.313s 0%
private-kernel-inner 0.068s -2%

Copy link
Contributor

github-actions bot commented Jan 7, 2025

Compilation Memory Report

Program Peak Memory
keccak256 77.68M
workspace 123.99M
regression_4709 424.20M
ram_blowup_regression 1.46G
rollup-root 601.09M
rollup-merge 494.09M
rollup-block-root-single-tx 16.06G
rollup-block-root-empty 488.22M
rollup-block-root 16.07G
rollup-block-merge 601.08M
rollup-base-public 2.38G
rollup-base-private 1.14G
private-kernel-tail 207.30M
private-kernel-reset 584.32M
private-kernel-inner 294.61M

Copy link
Contributor

github-actions bot commented Jan 7, 2025

Execution Memory Report

Program Peak Memory
keccak256 74.75M
workspace 123.88M
regression_4709 316.06M
ram_blowup_regression 512.64M
rollup-root 498.44M
rollup-merge 473.17M
rollup-block-root 1.22G
rollup-block-merge 498.45M
rollup-base-public 733.99M
rollup-base-private 590.63M
private-kernel-tail 180.75M
private-kernel-reset 245.36M
private-kernel-inner 208.77M

Copy link
Contributor

github-actions bot commented Jan 9, 2025

Changes to Brillig bytecode sizes

Generated at commit: 0ac3c3c0d800e712195aeff73398e98a027748a2, compared to commit: f17b7ccb075f1e7fb1ecfaf2807d350532ae3ebf

🧾 Summary (10% most significant diffs)

Program Brillig opcodes (+/-) %
u128_inliner_zero -10 ✅ -0.50%
to_bytes_consistent_inliner_zero -53 ✅ -41.09%

Full diff report 👇
Program Brillig opcodes (+/-) %
bigint_inliner_max 2,117 (+3) +0.14%
bigint_inliner_zero 2,241 (+3) +0.13%
u128_inliner_zero 1,995 (-10) -0.50%
to_bytes_consistent_inliner_zero 76 (-53) -41.09%

Copy link
Contributor

github-actions bot commented Jan 15, 2025

Changes to number of Brillig opcodes executed

Generated at commit: 0ac3c3c0d800e712195aeff73398e98a027748a2, compared to commit: f17b7ccb075f1e7fb1ecfaf2807d350532ae3ebf

🧾 Summary (10% most significant diffs)

Program Brillig opcodes (+/-) %
u128_inliner_zero +121 ❌ +0.27%
to_bytes_consistent_inliner_zero -35 ✅ -5.06%

Full diff report 👇
Program Brillig opcodes (+/-) %
u128_inliner_zero 44,748 (+121) +0.27%
to_bytes_consistent_inliner_zero 657 (-35) -5.06%

@michaeljklein michaeljklein marked this pull request as ready for review January 16, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add compile-time assertions on generic arguments of stdlib functions
2 participants