-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add compile-time assertions on generic arguments of stdlib functions #6981
Open
michaeljklein
wants to merge
25
commits into
master
Choose a base branch
from
michaeljklein/stdlib-static-assertions
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tatic_assert locations for field/mod.nr
michaeljklein
changed the title
Add compile-time assertions on generic arguments of stdlib functions
chore: add compile-time assertions on generic arguments of stdlib functions
Jan 7, 2025
Compilation Report
|
Execution Report
|
Compilation Memory Report
|
Execution Memory Report
|
TomAFrench
reviewed
Jan 7, 2025
…cks for numeric generics in field/mod.nr, fixed printing in test_transform_program_is_idempotent
…c_assert, ensure dynamic vars rejected by static_assert
TomAFrench
requested changes
Jan 9, 2025
Changes to Brillig bytecode sizes
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
…raint(input_expr_witness, bit_size)?;' for to_radix
Changes to number of Brillig opcodes executed
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
michaeljklein
commented
Jan 16, 2025
michaeljklein
commented
Jan 16, 2025
michaeljklein
commented
Jan 16, 2025
michaeljklein
commented
Jan 16, 2025
michaeljklein
commented
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves #6962
Summary*
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmt
on default settings.