Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: separate test compilation from test running #6737

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

TomAFrench
Copy link
Member

Description

Problem*

Resolves

Summary*

This PR separates out compilation from the run_test function. I've chosen to do this as compilation errors are all global as far as I know (i.e. if we can't compile one test program in a package then that will prevent any others from being compiled)

We can then have the run_test program take in a compiled program in order to improve separation of concerns.

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@TomAFrench TomAFrench requested a review from a team December 9, 2024 10:31
Copy link
Contributor

github-actions bot commented Dec 9, 2024

Peak Memory Sample

Program Peak Memory
keccak256 81.48M
workspace 122.06M
regression_4709 333.70M
ram_blowup_regression 2.55G

@TomAFrench TomAFrench marked this pull request as draft December 9, 2024 10:56
Copy link
Collaborator

@asterite asterite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactor!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants