Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agents: improve SaaS token handling #237

Closed

Conversation

santigimeno
Copy link
Member

While also making sure we're able to connect correctly to both production and staging hosts.

@santigimeno santigimeno added the P1 High priority label Dec 12, 2024
@santigimeno santigimeno self-assigned this Dec 12, 2024
@santigimeno
Copy link
Member Author

No specific tests for this. I need to create some JS bindings to expose grpc connection status first. It'll come in a follow-up PR. For the moment this will allow for staging testing.

@santigimeno santigimeno force-pushed the santi/improve_saas_token_parsing branch from 25be7dc to 5ef6c5e Compare December 30, 2024 10:38
While also making sure we're able to connect correctly to both
production and staging hosts.
@santigimeno santigimeno force-pushed the santi/improve_saas_token_parsing branch from 5ef6c5e to 36f5982 Compare December 30, 2024 13:20
Copy link
Contributor

@juanarbol juanarbol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

santigimeno added a commit that referenced this pull request Jan 2, 2025
While also making sure we're able to connect correctly to both
production and staging hosts.

PR-URL: #237
Reviewed-By: Juan José Arboleda <[email protected]>
@santigimeno
Copy link
Member Author

santigimeno commented Jan 2, 2025

Landed in fd5e947

@santigimeno santigimeno closed this Jan 2, 2025
@santigimeno santigimeno deleted the santi/improve_saas_token_parsing branch January 2, 2025 10:35
santigimeno added a commit that referenced this pull request Jan 2, 2025
While also making sure we're able to connect correctly to both
production and staging hosts.

PR-URL: #237
Reviewed-By: Juan José Arboleda <[email protected]>
santigimeno added a commit that referenced this pull request Jan 3, 2025
While also making sure we're able to connect correctly to both
production and staging hosts.

PR-URL: #237
Reviewed-By: Juan José Arboleda <[email protected]>
santigimeno added a commit that referenced this pull request Jan 9, 2025
While also making sure we're able to connect correctly to both
production and staging hosts.

PR-URL: #237
Reviewed-By: Juan José Arboleda <[email protected]>
santigimeno added a commit that referenced this pull request Jan 13, 2025
While also making sure we're able to connect correctly to both
production and staging hosts.

PR-URL: #237
Reviewed-By: Juan José Arboleda <[email protected]>
PR-URL: #245
Reviewed-By: Rafael Gonzaga <[email protected]>
santigimeno added a commit that referenced this pull request Jan 13, 2025
While also making sure we're able to connect correctly to both
production and staging hosts.

PR-URL: #237
Reviewed-By: Juan José Arboleda <[email protected]>
PR-URL: #246
Reviewed-By: Rafael Gonzaga <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 High priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants