Skip to content

Add building luac.cross to travis ci builds #2682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 9, 2019

Conversation

HHHartmann
Copy link
Member

@HHHartmann HHHartmann commented Feb 24, 2019

Give it a spin on all lua files afterwards

Fixes #2681.

Make sure all boxes are checked (add x inside the brackets) when you submit your contribution, remove this sentence before doing so.

  • This PR is for the dev branch rather than for master.
  • This PR is compliant with the other contributing guidelines as well (if not, please describe why).
  • I have thoroughly tested my contribution.
  • The code changes are reflected in the documentation at docs/en/*.

Give it a spin on all lua files afterwards
@HHHartmann
Copy link
Member Author

I thought about that too but did not want to generate a bunch of extra scripts.
Also the common part would be ugly to implement depending on a variable being set in the platform dependent part.
Also more testing would have to be done as I am not so sure how to make the script break on any error.

If going for scripts I would like to implement a common naming convention or even an extra directory.
tools/travis maybe?

I probably will not find time to work on this in the next couple of weeks so maybe adding scripts could be deferred to a followup PR.

@HHHartmann
Copy link
Member Author

How can I trigger a travis build for this

@marcelstoer marcelstoer added this to the Next release milestone Apr 5, 2019
@HHHartmann
Copy link
Member Author

Travis-CI build succeeds, so could this be accepted?

@TerryE TerryE merged commit 9842a8e into nodemcu:dev Apr 9, 2019
@HHHartmann HHHartmann deleted the add-msbuild-to-travis branch April 9, 2019 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants