Add web-infra onboarding docs #17
Open
+32
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: flakey5 <[email protected]>
flakey5
commented
Jul 13, 2025
avivkeller
reviewed
Jul 13, 2025
|
@flakey5 I also believe we could document our Slack channels on the onboarding doc and what they server for. (there's the website one, alerts one, i18n one for website, and others I gues?) |
|
OOC, why is the PR blocked? |
|
@flakey5 I forgot, we also have this list for Crowdin: https://github.com/nodejs/email/blob/main/iojs.org/aliases.json#L175 Can you also add this to the onboarding docs, we also need the current remaining members of web-infra added there! |
Per the PR description,
|
MattIPv4
reviewed
Jul 16, 2025
Co-authored-by: Aviv Keller <[email protected]> Co-authored-by: Matt Cowley <[email protected]>
|
Hey @flakey5 just wondering if you're still OOO (vacations); Should we take over this PR or? |
Signed-off-by: flakey5 <[email protected]>
Apologizes got side tracked, updated from reviews but I think this should still be blocked since nodejs/admin#984 is still open |
2 tasks
Agreed |
avivkeller
approved these changes
Oct 11, 2025
Comment on lines
+1
to
+8
| # @nodejs/web-infra Onboarding | ||
|
|
||
| This document is an outline of the tasks necessary to onboard a new member of the Web Infrastructure team (@nodejs/web-infra). | ||
|
|
||
| Please note these tasks should only be performed after an individual's nomination has passed. | ||
| To start the nomination process, see [GOVERNANCE.md](../GOVERNANCE.md). | ||
|
|
||
| ## Tasks |
There was a problem hiding this comment.
Suggested change
| # @nodejs/web-infra Onboarding | |
| This document is an outline of the tasks necessary to onboard a new member of the Web Infrastructure team (@nodejs/web-infra). | |
| Please note these tasks should only be performed after an individual's nomination has passed. | |
| To start the nomination process, see [GOVERNANCE.md](../GOVERNANCE.md). | |
| ## Tasks | |
| ## @nodejs/web-infra Onboarding |
Let's make this uniform w/ https://github.com/nodejs/web-team/blob/main/onboarding/nodejs-website.md?plain=1
Comment on lines
+10
to
+12
| - [ ] The nominee should open a pull request in [nodejs/web-team](https://github.com/nodejs/web-team) adding themselves to the [MEMBERS.md](https://github.com/nodejs/web-team/blob/main/MEMBERS.md#nodejs-web-infra-team-nodejsweb-infra) document. | ||
| - [ ] Nominee should include this list in the pull request's body to keep track of what has been completed for their onboarding. The pull request should not be merged until the onboarding tasks have been completed. | ||
| - [ ] Please link any additional issues or pull requests back to this one for record keeping purposes. |
There was a problem hiding this comment.
Suggested change
| - [ ] The nominee should open a pull request in [nodejs/web-team](https://github.com/nodejs/web-team) adding themselves to the [MEMBERS.md](https://github.com/nodejs/web-team/blob/main/MEMBERS.md#nodejs-web-infra-team-nodejsweb-infra) document. | |
| - [ ] Nominee should include this list in the pull request's body to keep track of what has been completed for their onboarding. The pull request should not be merged until the onboarding tasks have been completed. | |
| - [ ] Please link any additional issues or pull requests back to this one for record keeping purposes. |
https://github.com/nodejs/web-team/blob/main/onboarding/README.md?plain=1#L10
| - [ ] The nominee should open a pull request in [nodejs/web-team](https://github.com/nodejs/web-team) adding themselves to the [MEMBERS.md](https://github.com/nodejs/web-team/blob/main/MEMBERS.md#nodejs-web-infra-team-nodejsweb-infra) document. | ||
| - [ ] Nominee should include this list in the pull request's body to keep track of what has been completed for their onboarding. The pull request should not be merged until the onboarding tasks have been completed. | ||
| - [ ] Please link any additional issues or pull requests back to this one for record keeping purposes. | ||
| - [ ] A Web Admin should add the nominee to the [@nodejs/web-infra](https://github.com/orgs/nodejs/teams/web-infra) team. |
There was a problem hiding this comment.
Suggested change
| - [ ] A Web Admin should add the nominee to the [@nodejs/web-infra](https://github.com/orgs/nodejs/teams/web-infra) team. | |
| - [ ] Add the **Nominee** to the @nodejs/web-infra team on GitHub. |
| - [ ] Nominee should include this list in the pull request's body to keep track of what has been completed for their onboarding. The pull request should not be merged until the onboarding tasks have been completed. | ||
| - [ ] Please link any additional issues or pull requests back to this one for record keeping purposes. | ||
| - [ ] A Web Admin should add the nominee to the [@nodejs/web-infra](https://github.com/orgs/nodejs/teams/web-infra) team. | ||
| - [ ] The nominee should open an issue in [nodejs/admin](https://github.com/nodejs/admin) requesting access to the Web Infra 1Password vault. |
There was a problem hiding this comment.
Suggested change
| - [ ] The nominee should open an issue in [nodejs/admin](https://github.com/nodejs/admin) requesting access to the Web Infra 1Password vault. | |
| - [ ] Grant the **Nominee** access to the Web Infra 1Password vault. The **Nominee** can request this access by opening an issue on [nodejs/admin](https://github.com/nodejs/admin). |
| - [ ] Please link any additional issues or pull requests back to this one for record keeping purposes. | ||
| - [ ] A Web Admin should add the nominee to the [@nodejs/web-infra](https://github.com/orgs/nodejs/teams/web-infra) team. | ||
| - [ ] The nominee should open an issue in [nodejs/admin](https://github.com/nodejs/admin) requesting access to the Web Infra 1Password vault. | ||
| - [ ] A Web Admin should invite the nominee to Node.js' Sentry account. |
There was a problem hiding this comment.
Suggested change
| - [ ] A Web Admin should invite the nominee to Node.js' Sentry account. | |
| - [ ] Grant the **Nominee** access to Sentry. |
| - [ ] A Web Admin should add the nominee to the [@nodejs/web-infra](https://github.com/orgs/nodejs/teams/web-infra) team. | ||
| - [ ] The nominee should open an issue in [nodejs/admin](https://github.com/nodejs/admin) requesting access to the Web Infra 1Password vault. | ||
| - [ ] A Web Admin should invite the nominee to Node.js' Sentry account. | ||
| - [ ] The nominee should enable physical or passkey 2FA on their Sentry account. |
There was a problem hiding this comment.
Suggested change
| - [ ] The nominee should enable physical or passkey 2FA on their Sentry account. | |
| - [ ] The **Nominee** should enable physical or passkey 2FA on their Sentry account. |
| - [ ] The nominee should open an issue in [nodejs/admin](https://github.com/nodejs/admin) requesting access to the Web Infra 1Password vault. | ||
| - [ ] A Web Admin should invite the nominee to Node.js' Sentry account. | ||
| - [ ] The nominee should enable physical or passkey 2FA on their Sentry account. | ||
| - [ ] A Web Admin should invite the nominee to Node.js' Vercel account. |
There was a problem hiding this comment.
Suggested change
| - [ ] A Web Admin should invite the nominee to Node.js' Vercel account. | |
| - [ ] Grant the **Nominee** access to Vercel. |
| - [ ] The nominee should enable physical or passkey 2FA on their Sentry account. | ||
| - [ ] A Web Admin should invite the nominee to Node.js' Vercel account. | ||
| - [ ] The nominee should enable physical or passkey 2FA on their Vercel account. | ||
| - [ ] The nominee should open a pull request in [nodejs/email](https://github.com/nodejs/email) to add their email to the `nodejs-crowdin` email chain. |
There was a problem hiding this comment.
Suggested change
| - [ ] The nominee should open a pull request in [nodejs/email](https://github.com/nodejs/email) to add their email to the `nodejs-crowdin` email chain. | |
| - [ ] The **Nominee** should add their email to the following aliases | |
| - [ ] [`nodejs-crowdin`](https://github.com/nodejs/email/blob/main/iojs.org/aliases.json#L174) | |
| - [ ] [`nodejs-vercel`](https://github.com/nodejs/email/blob/main/iojs.org/aliases.json#L241) |
| - [ ] A Web Admin should invite the nominee to Node.js' Sentry account. | ||
| - [ ] The nominee should enable physical or passkey 2FA on their Sentry account. | ||
| - [ ] A Web Admin should invite the nominee to Node.js' Vercel account. | ||
| - [ ] The nominee should enable physical or passkey 2FA on their Vercel account. |
There was a problem hiding this comment.
This can go under ## Recommendations, right?
Comment on lines
+24
to
+26
| - [ ] A Web Admin should recommend the nominee have some form of physical 2FA (i.e. Yubikey) or passkey enabled on their GitHub account | ||
| - [ ] A Web Admin should recommend any SSH or GPG key attached to their GitHub account have passphrases or be stored on a physical 2FA device. | ||
| - [ ] A Web Admin should recommend the nominee sign their Git commits. |
There was a problem hiding this comment.
Suggested change
| - [ ] A Web Admin should recommend the nominee have some form of physical 2FA (i.e. Yubikey) or passkey enabled on their GitHub account | |
| - [ ] A Web Admin should recommend any SSH or GPG key attached to their GitHub account have passphrases or be stored on a physical 2FA device. | |
| - [ ] A Web Admin should recommend the nominee sign their Git commits. | |
| - [ ] The **Nominee** should have some form of physical 2FA (i.e. Yubikey) or passkey enabled on their GitHub account. | |
| - [ ] The **Nominee** should have a SSH or GPG key attached to their GitHub account have passphrases or be stored on a physical 2FA device. | |
| - [ ] The **Nominee** should sign their Git commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re #5
Note: blocked until nodejs/admin#984 goes through since this mentions the
web-adminsteam.