Skip to content

Conversation

@ovflowd
Copy link
Member

@ovflowd ovflowd commented Nov 23, 2025

This PR updates our ESLint rules in a way that type imports are their own group and cleanses a bit the groupped imports.

@ovflowd ovflowd requested a review from a team as a code owner November 23, 2025 15:09
Copilot AI review requested due to automatic review settings November 23, 2025 15:09
@ovflowd ovflowd requested a review from a team as a code owner November 23, 2025 15:09
@vercel
Copy link

vercel bot commented Nov 23, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
nodejs-org Ready Ready Preview Nov 23, 2025 3:10pm

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the ESLint import ordering rules to separate type-only imports into their own distinct group, improving code organization and readability across the entire codebase. The change adds 'object' and 'type' groups to the import ordering configuration while removing the 'unknown' group.

Key Changes

  • Modified ESLint configuration to include 'object' and 'type' import groups
  • Reorganized imports in 150+ files to separate type imports from regular imports
  • Added consistent blank line separation between import groups throughout the codebase

Reviewed changes

Copilot reviewed 247 out of 247 changed files in this pull request and generated no comments.

File Description
eslint.config.js Added 'object' and 'type' groups to import ordering, removed 'unknown' group
packages/ui-components/src/**/*.tsx Reorganized imports to separate type imports from regular imports
apps/site/**/*.ts(x) Applied consistent import grouping with type imports in separate blocks

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Nov 23, 2025

Codecov Report

❌ Patch coverage is 78.57143% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.41%. Comparing base (bfaa6f8) to head (babbf6f).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...s/src/Common/BasePagination/useGetPageElements.tsx 0.00% 3 Missing ⚠️
packages/ui-components/src/Common/Select/index.tsx 33.33% 2 Missing ⚠️
...ges/ui-components/src/Containers/MetaBar/index.tsx 0.00% 2 Missing ⚠️
apps/site/reducers/releaseReducer.ts 0.00% 1 Missing ⚠️
.../ui-components/src/Common/BaseActiveLink/index.tsx 0.00% 1 Missing ⚠️
...ages/ui-components/src/Common/BaseButton/index.tsx 0.00% 1 Missing ⚠️
...Common/BasePagination/PaginationListItem/index.tsx 0.00% 1 Missing ⚠️
.../ui-components/src/Common/BasePagination/index.tsx 50.00% 1 Missing ⚠️
...ckages/ui-components/src/Common/Skeleton/index.tsx 50.00% 1 Missing ⚠️
packages/ui-components/src/Icons/Logos/JsWhite.tsx 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8362      +/-   ##
==========================================
+ Coverage   76.22%   76.41%   +0.18%     
==========================================
  Files         118      118              
  Lines        9903     9928      +25     
  Branches      337      334       -3     
==========================================
+ Hits         7549     7586      +37     
+ Misses       2352     2340      -12     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@canerakdas canerakdas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants