-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
chore: update running typescript natively documentation #8361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the documentation for running TypeScript natively in Node.js to reflect that the feature is no longer experimental as of v25.2.0 and that type stripping is enabled by default in v22.18.0+. The documentation has been restructured to prioritize the simpler, default behavior for modern Node.js versions.
Key changes:
- Reorganized content to lead with the default behavior (v22.18.0+) rather than experimental flags
- Updated language to reflect stability in v25.2.0
- Changed section title from "Limitations" to "Constraints"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8361 +/- ##
==========================================
+ Coverage 76.23% 76.27% +0.04%
==========================================
Files 118 118
Lines 9903 9903
Branches 337 336 -1
==========================================
+ Hits 7550 7554 +4
+ Misses 2351 2347 -4
Partials 2 2 ☔ View full report in Codecov by Sentry. |
AugustinMauroy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT !
ovflowd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TYSM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
a small suggestion:
this whole section is sorta odd now that we are stable. i suggest removing. we always welcome feedback, this is the default
2328a8d to
02c7f64
Compare
bjohansebas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Michael Esteban <[email protected]> Signed-off-by: Marco Ippolito <[email protected]>
| enum MyEnum { | ||
| A, | ||
| B, | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How come the example with the enum was removed?
Co-authored-by: Steven <[email protected]> Signed-off-by: Brian Muenzenmeyer <[email protected]>
📦 Build Size ComparisonSummary
Changes➕ Added Assets (1)
➖ Removed Assets (1)
|
|
idk why tests are failing, it seems unrelated, can someone take a look? |
|
It's unrelated to this PR. I think the action is restoring a cached version of |
updated the documentation since all node.js versions dont need
--experimental-strip-typesflag to work and the feature is no longer experimental in v25.2.0@nodejs/typescript