Skip to content

docs: require community installation methods are non-commercial FOSS #7631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 11, 2025

Conversation

MattIPv4
Copy link
Member

@MattIPv4 MattIPv4 commented Apr 9, 2025

Description

As has been discussed in Slack, and in #7536 (comment), it is desired that any community installation method listed on the site should be available for any user of Node.js to use for free without any ties to a commercial product, and open-source to allow the user to inspect what will be run on their system.

Validation

Please don your lawyer hat/glasses and read the wording.

Related Issues

cc #7616

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@Copilot Copilot AI review requested due to automatic review settings April 9, 2025 01:40
@MattIPv4 MattIPv4 requested a review from a team as a code owner April 9, 2025 01:40
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • apps/site/pages/en/about/previous-releases.mdx: Language not supported

Copy link

vercel bot commented Apr 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Apr 11, 2025 7:27pm

@bjohansebas
Copy link
Member

cc @nodejs/package-maintenance

Copy link
Contributor

github-actions bot commented Apr 9, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 99 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 98 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

Copy link
Contributor

github-actions bot commented Apr 9, 2025

Unit Test Coverage Report

Title Lines Statements Branches Functions
@node-core/ui-components Coverage: 95%
95.83% (161/168) 77.86% (102/131) 88.57% (31/35)
@nodejs/website Coverage: 87%
84.7% (493/582) 76.03% (165/217) 86.88% (106/122)
Title Tests Skipped Failures Errors Time
@node-core/ui-components 24 0 💤 0 ❌ 0 🔥 4.989s ⏱️
@nodejs/website 156 0 💤 0 ❌ 0 🔥 6.589s ⏱️

@ovflowd
Copy link
Member

ovflowd commented Apr 9, 2025

Just to clarify that this was already agreed upon, and simply got forgotten on my previous PR.

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@wesleytodd wesleytodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should address the question about existing for-profit and non-oss tools before landing this.

Signed-off-by: Matt Cowley <me@mattcowley.co.uk>
@ovflowd ovflowd enabled auto-merge April 11, 2025 19:33
@ovflowd ovflowd added this pull request to the merge queue Apr 11, 2025
Merged via the queue into main with commit 9d0b590 Apr 11, 2025
22 checks passed
@ovflowd ovflowd deleted the MattIPv4/free-oss-community-installations branch April 11, 2025 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants