Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): hover active item #7620

Merged
merged 1 commit into from
Apr 8, 2025
Merged

Conversation

AugustinMauroy
Copy link
Member

Description

without this change when hover active item it's take the style of the over and that's strange

Related Issues

No Related issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@Copilot Copilot bot review requested due to automatic review settings April 4, 2025 09:24
@AugustinMauroy AugustinMauroy requested a review from a team as a code owner April 4, 2025 09:24
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • packages/ui-components/Common/BasePagination/PaginationListItem/index.module.css: Language not supported

Copy link

vercel bot commented Apr 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Apr 4, 2025 9:24am

Copy link
Contributor

github-actions bot commented Apr 4, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 99 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟠 88 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

Copy link
Contributor

github-actions bot commented Apr 4, 2025

Unit Test Coverage Report

Title Lines Statements Branches Functions
@node-core/ui-components Coverage: 95%
95.83% (161/168) 77.86% (102/131) 88.57% (31/35)
@nodejs/website Coverage: 87%
84.73% (494/583) 76.03% (165/217) 86.99% (107/123)
Title Tests Skipped Failures Errors Time
@node-core/ui-components 24 0 💤 0 ❌ 0 🔥 4.72s ⏱️
@nodejs/website 156 0 💤 0 ❌ 0 🔥 6.231s ⏱️

@bmuenzenmeyer
Copy link
Collaborator

@AugustinMauroy can you please provide more detail here on how one should test?
I think you removed the Validation instructions from the PR template, which is explicitly made to help reviewers know how changes are working

@AugustinMauroy
Copy link
Member Author

I'll do that I wasn't at home that why I didn't add record

@AugustinMauroy
Copy link
Member Author

AugustinMauroy commented Apr 7, 2025

@bmuenzenmeyer

Before

before # After after

@avivkeller avivkeller added this pull request to the merge queue Apr 8, 2025
Merged via the queue into main with commit ca4c7a3 Apr 8, 2025
15 checks passed
@avivkeller avivkeller deleted the fix-ui-active+hover-pagination branch April 8, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants