Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(blog): add and normalize authors #7619

Merged
merged 6 commits into from
Apr 7, 2025
Merged

chore(blog): add and normalize authors #7619

merged 6 commits into from
Apr 7, 2025
+83 −47

Conversation

AugustinMauroy
Copy link
Member

@AugustinMauroy AugustinMauroy commented Apr 4, 2025 •
edited
Loading

Description

Clean and normalize authors in blog

Capture d’écran 2025-04-04 à 10 02 20 Capture d’écran 2025-04-04 à 10 02 41 Capture d’écran 2025-04-04 à 10 02 58

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.

@Copilot Copilot bot review requested due to automatic review settings April 4, 2025 08:01
@AugustinMauroy AugustinMauroy requested review from a team as code owners April 4, 2025 08:01
@vercel Vercel
Copy link

vercel bot commented Apr 4, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Apr 7, 2025 0:21am

Copilot
Copilot AI reviewed Apr 4, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 40 out of 41 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • apps/site/authors.json: Language not supported

@AugustinMauroy AugustinMauroy added the github_actions:pull-request Trigger Pull Request Checks label Apr 4, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Apr 4, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 4, 2025 •
edited
Loading

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟠 89 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 100 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 97 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

@AugustinMauroy AugustinMauroy added the github_actions:pull-request Trigger Pull Request Checks label Apr 4, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Apr 4, 2025
@AugustinMauroy AugustinMauroy added the github_actions:pull-request Trigger Pull Request Checks label Apr 4, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Apr 4, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 4, 2025 •
edited
Loading

Unit Test Coverage Report

Title Lines Statements Branches Functions
@node-core/ui-components Coverage: 95%
 95.83% (161/168) 77.86% (102/131) 88.57% (31/35)
@nodejs/website Coverage: 87%
 84.73% (494/583) 76.03% (165/217) 86.99% (107/123)
Title Tests Skipped Failures Errors Time
@node-core/ui-components 24 0 💤 0 ❌ 0 🔥 4.645s ⏱️
@nodejs/website 156 0 💤 0 ❌ 0 🔥 6.227s ⏱️

@avivkeller

This comment has been minimized.

Sign in to view
@AugustinMauroy

This comment has been minimized.

Sign in to view
RafaelGSS
RafaelGSS approved these changes Apr 4, 2025
View reviewed changes
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@AugustinMauroy @RafaelGSS
use tsc repo as website
924f2b4 
Co-authored-by: Rafael Gonzaga <[email protected]>
Signed-off-by: Augustin Mauroy <[email protected]>
@bjohansebas bjohansebas added the github_actions:pull-request Trigger Pull Request Checks label Apr 6, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Apr 6, 2025
@bjohansebas bjohansebas enabled auto-merge April 6, 2025 18:34
@bjohansebas bjohansebas disabled auto-merge April 6, 2025 18:34
@AugustinMauroy AugustinMauroy added the github_actions:pull-request Trigger Pull Request Checks label Apr 7, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Apr 7, 2025
@AugustinMauroy AugustinMauroy added this pull request to the merge queue Apr 7, 2025
Merged via the queue into main with commit 52491f9 Apr 7, 2025
14 checks passed
@AugustinMauroy AugustinMauroy deleted the chore-blog branch April 7, 2025 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@avivkeller avivkeller avivkeller approved these changes

@bjohansebas bjohansebas bjohansebas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AugustinMauroy @avivkeller @RafaelGSS @bjohansebas