Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(about): list official resources #7562

Merged
merged 7 commits into from
Apr 10, 2025
Merged

feat(about): list official resources #7562

merged 7 commits into from
Apr 10, 2025

Conversation

avivkeller
Copy link
Member

Description

This PR lists official resources on the “About” page, so that users are steered away from unofficial, and possibly dangerous, resources.

I’m not sure if the TSC needs to sign off on this, to make sure that everything that should be included is.

Validation

Check the “About” page for the added information

Related Issues

Fixes #7050

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@Copilot Copilot bot review requested due to automatic review settings March 22, 2025 17:25
@avivkeller avivkeller requested a review from a team as a code owner March 22, 2025 17:25
Copilot
Copilot AI reviewed Mar 22, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • apps/site/pages/en/about/index.mdx: Language not supported

@vercel Vercel
Copy link

vercel bot commented Mar 22, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Apr 9, 2025 4:34pm

@avivkeller avivkeller added the content Issues/pr concerning content label Mar 22, 2025
@avivkeller
Copy link
Member Author

See the edited About page: https://nodejs-org-git-feat-official-resources-openjs.vercel.app/en/about

bjohansebas
bjohansebas reviewed Mar 22, 2025
View reviewed changes
Copy link
Member

@bjohansebas bjohansebas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ovflowd
Copy link
Member

ovflowd commented Mar 22, 2025

cc @nodejs/tsc as this is content updates. I feel confident with these updates, but just pining y'all in.

AugustinMauroy
AugustinMauroy approved these changes Mar 22, 2025
View reviewed changes
Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@bjohansebas bjohansebas mentioned this pull request Mar 22, 2025
Open
@avivkeller
Copy link
Member Author

avivkeller commented Mar 22, 2025 •
edited
Loading

I've removed mention to other packages for now.

If it's agreed upon that they should be listed, and someone can provide a definitive list, I'll add them into this PR.

Also see nodejs/admin#959

@avivkeller
Copy link
Member Author

Hey TSC! Have you reached a consensus on whether or not we need to include a list of packages in this PR?

@ovflowd
Copy link
Member

ovflowd commented Apr 3, 2025

Hey TSC! Have you reached a consensus on whether or not we need to include a list of packages in this PR?

@nodejs/tsc

@avivkeller
Copy link
Member Author

I'm excelating this to the TSC agenda, as they are meeting in a few days (nodejs/TSC#1712). If they reach consensus before said date, or there is a change of heart on the addition of the agenda label, feel free to remove

@avivkeller avivkeller mentioned this pull request Apr 8, 2025
Open
@targos
Copy link
Member

targos commented Apr 9, 2025

We discussed briefly during the TSC meeting and it was not clear what you are expecting from the group. Given that multiple TSC members have been involved in the PR and there are no blocks, we considered this a ping for awareness.

@targos targos removed the tsc-agenda label Apr 9, 2025
@avivkeller
Copy link
Member Author

Apologies if that was unclear — we were seeking a consensus on whether to list individual packages or only organization-controlled accounts. Seeing as there are no blocks, we will continue with only listing accounts for now.

@avivkeller avivkeller force-pushed the feat/official-resources branch from d452ad9 to e174656 Compare April 9, 2025 16:18
@avivkeller avivkeller added the github_actions:pull-request Trigger Pull Request Checks label Apr 9, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Apr 9, 2025
@avivkeller
Copy link
Member Author

Please re-review with any final concerns, and merge-at-will.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 9, 2025 •
edited
Loading

Unit Test Coverage Report

Title Lines Statements Branches Functions
@node-core/ui-components Coverage: 95%
 95.83% (161/168) 77.86% (102/131) 88.57% (31/35)
@nodejs/website Coverage: 87%
 84.73% (494/583) 76.03% (165/217) 86.99% (107/123)
Title Tests Skipped Failures Errors Time
@node-core/ui-components 24 0 💤 0 ❌ 0 🔥 4.918s ⏱️
@nodejs/website 156 0 💤 0 ❌ 0 🔥 6.678s ⏱️

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 9, 2025 •
edited
Loading

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟠 81 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 100 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 98 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

mcollina
mcollina approved these changes Apr 9, 2025
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@avivkeller avivkeller added the github_actions:pull-request Trigger Pull Request Checks label Apr 9, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Apr 9, 2025
@avivkeller avivkeller added this pull request to the merge queue Apr 10, 2025
Merged via the queue into main with commit 4fcc18f Apr 10, 2025
14 checks passed
@avivkeller avivkeller deleted the feat/official-resources branch April 10, 2025 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@anonrig anonrig anonrig left review comments

@ovflowd ovflowd ovflowd left review comments

@marco-ippolito marco-ippolito marco-ippolito left review comments

@AugustinMauroy AugustinMauroy AugustinMauroy approved these changes

Copilot code review Copilot Copilot left review comments

@bjohansebas bjohansebas bjohansebas approved these changes

Assignees
No one assigned
Labels
content Issues/pr concerning content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Status Page link to README / and/or website
8 participants
@avivkeller @ovflowd @targos @mcollina @anonrig @marco-ippolito @AugustinMauroy @bjohansebas