Skip to content

test: fix on zfs build host - #67517

Open
MarcelCoding wants to merge 1 commit into
nodejs:mainfrom
MarcelCoding:fix-tests-on-zfs
Open

MarcelCoding wants to merge 1 commit into
nodejs:mainfrom
MarcelCoding:fix-tests-on-zfs

Conversation

@MarcelCoding

@MarcelCoding MarcelCoding commented Nov 16, 2026 •

Copy link
Copy Markdown

Sucessfuly build using the nix environment on a ZFS build host using:

From 7a826a8d7ad1a478c55afa7286d3fc894ee14fed Mon Sep 17 00:00:00 2001
From: Marcel <me@m4rc3l.de>
Date: Sun, 15 Nov 2026 21:41:03 +0100
Subject: [PATCH] nodejs: fix build on zfs

---
 pkgs/development/web/nodejs/nodejs.nix | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/pkgs/development/web/nodejs/nodejs.nix b/pkgs/development/web/nodejs/nodejs.nix
index 8d682600afd0..b08f285b6b1e 100644
--- a/pkgs/development/web/nodejs/nodejs.nix
+++ b/pkgs/development/web/nodejs/nodejs.nix
@@ -354,7 +354,13 @@ let
 
       pos = builtins.unsafeGetAttrPos "version" args;
 
-      inherit patches;
+      patches = patches ++ [
+        (fetchpatch2 {
+        name = "test-fix-on-zfs-build-host.patch";
+          url = "https://github.com/MarcelCoding/node/commit/bb96340faddd5e9441848f7634b36452407becb3.patch?full_index=1";
+          hash = "sha256-FH6rSroKAxLqqJNkJYgyp3NgAwTnm5cXDa4cq6pH9d0=";
+        })
+      ];
 
       postPatch = ''
         substituteInPlace tools/install.py \

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Nov 16, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Welcome to Node.js, and thank you for your first contribution!

Before review, please take a moment to read:

Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal.

Signed-off-by: Marcel <me@m4rc3l.de>
@aduh95

aduh95 commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

Is this ready for reviews? Did you confirm you were able to build nodejs-slim on ZFS with that patch?

@MarcelCoding

Copy link
Copy Markdown
Author

Yes, the build finished in the meantime. But I still have to check the contribution guides etc.

@MarcelCoding
MarcelCoding marked this pull request as ready for review November 16, 2026 15:50
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Nov 16, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 16, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants