Repository navigation
Conversation
The location of a test file run in a child process was resolved against `process.cwd()`, so `run()` reported a wrong `entryFile` for relative paths when called with a different `cwd`. Signed-off-by: Moshe Atlow <moshe@atlow.co.il>
With process isolation, the `--test-rerun-failures` state file is written by the parent process, which numbered tests sharing a location across all test files, while each child process numbers them within its own file. A test defined in a helper used by several test files was therefore looked up in a slot belonging to another file, and a failing test could be replayed as passed without running. Prefix the identifier of a test defined outside of its entry file with the entry file when tests run in per-file child processes, and build the identifier with the same helper on both sides. Signed-off-by: Moshe Atlow <moshe@atlow.co.il>
Collaborator
|
Review requested:
|
atlowChemi
approved these changes
Nov 16, 2026
Collaborator
benjamingr
approved these changes
Nov 16, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #67512 +/- ##
==========================================
- Coverage 90.68% 90.66% -0.03%
==========================================
Files 799 799
Lines 280246 280260 +14
Branches 54113 54121 +8
==========================================
- Hits 254150 254090 -60
- Misses 16234 16284 +50
- Partials 9862 9886 +24
🚀 New features to boost your workflow:
|
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With process isolation, the
--test-rerun-failuresstate file iswritten by the parent process, which numbered tests sharing a location
across all test files, while each child process numbers them within
its own file. A test defined in a helper used by several test files
was therefore looked up in a slot belonging to another file, and a
failing test could be replayed as passed without running.
Prefix the identifier of a test defined outside of its entry file with
the entry file when tests run in per-file child processes, and build
the identifier with the same helper on both sides.