Skip to content

doc: fix http response.writeInformation() signature - #67492

Open
inoway46 wants to merge 1 commit into
nodejs:mainfrom
inoway46:doc-http-write-information-signature
Open

inoway46 wants to merge 1 commit into
nodejs:mainfrom
inoway46:doc-http-write-information-signature

Conversation

@inoway46

Copy link
Copy Markdown
Contributor

While working on #67470, I noticed that the documented signature doesn't match the implementation: response.writeInformation(102, callback) throws ERR_INVALID_ARG_TYPE, because the second argument is always treated as headers.

The second argument is always treated as `headers`, so `callback`
cannot be passed without it.

Signed-off-by: inoway46 <inoueyuya416@gmail.com>
Assisted-by: Claude Code
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. http Issues and PRs related to the http subsystem. labels Nov 15, 2026
@inoway46
inoway46 marked this pull request as ready for review November 15, 2026 16:47
@inoway46 inoway46 added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. doc Issues and PRs related to Node.js documentation. http Issues and PRs related to the http subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants