Skip to content

tools: lint crypto backend alternatives - #67466

Closed
panva wants to merge 2 commits into
nodejs:mainfrom
panva:crypto-backend-lint
Closed

panva wants to merge 2 commits into
nodejs:mainfrom
panva:crypto-backend-lint

Conversation

@panva

@panva panva commented Nov 14, 2026

Copy link
Copy Markdown
Member

Require backend alternatives to end with a final #else containing an unconditional #error "Unsupported crypto backend". Keep single-backend gates valid and track nested conditionals independently.

Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Require backend alternatives to end with a final #else containing an
unconditional #error "Unsupported crypto backend". Keep single-backend
gates valid and track nested conditionals independently.

Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Assisted-by: Codex
@panva panva added commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v26.x PRs that should not land on the v26.x-staging branch and should not be released in v26.x. labels Nov 14, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Nov 14, 2026
@panva panva closed this Nov 14, 2026
@panva
panva deleted the crypto-backend-lint branch November 14, 2026 11:16
@codecov

codecov Bot commented Nov 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.69%. Comparing base (925faf4) to head (7f28d1d).
⚠️ Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #67466      +/-   ##
==========================================
- Coverage   90.70%   90.69%   -0.01%     
==========================================
  Files         802      802              
  Lines      282109   282176      +67     
  Branches    54364    54372       +8     
==========================================
+ Hits       255881   255925      +44     
- Misses      16359    16370      +11     
- Partials     9869     9881      +12     
Files with missing lines Coverage Δ
src/crypto/crypto_hash.cc 79.77% <ø> (+0.55%) ⬆️
src/crypto/crypto_x509_gen.cc 68.26% <ø> (ø)

... and 42 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. crypto Issues and PRs related to the crypto subsystem. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v26.x PRs that should not land on the v26.x-staging branch and should not be released in v26.x. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants