Skip to content

url: restrict option copying in urlToHttpOptions to URL instances - #67454

Open
mcollina wants to merge 1 commit into
nodejs:mainfrom
mcollina:fix-urltohttpoptions-options-injection
Open

mcollina wants to merge 1 commit into
nodejs:mainfrom
mcollina:fix-urltohttpoptions-options-injection

Conversation

@mcollina

Copy link
Copy Markdown
Member

urlToHttpOptions() currently spreads all own enumerable properties of its argument into the request options. When http.request()/https.request() is passed a URL-shaped object that satisfies the duck-typed isURL() check but is not a genuine WHATWG URL instance, arbitrary transport/connection options such as socketPath, method, headers, or agent are copied into the request options. This lets an attacker-supplied object redirect a hostname-validated request to a Unix domain socket (for example the Docker daemon), defeating hostname-based SSRF defenses.

The spread is only meaningful for a genuine WHATWG URL instance that a user has extended with additional own enumerable properties (for example url.headers = ...), as introduced in #46989. A real URL instance has no own enumerable properties of its own, so gating the spread on the existing isURLInstance() brand check preserves that feature while preventing the duck-typed smuggling vector.

Adds a unit test in test-url-urltooptions.js and an end-to-end regression test verifying that a hostname-validated request is no longer redirected to an injected socketPath.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/url

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Nov 13, 2026
@mcollina
mcollina force-pushed the fix-urltohttpoptions-options-injection branch from 38881e3 to 75bfa0e Compare November 13, 2026 12:56
@codecov

codecov Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.70%. Comparing base (2929073) to head (edbd599).
⚠️ Report is 88 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #67454      +/-   ##
==========================================
- Coverage   92.62%   90.70%   -1.92%     
==========================================
  Files         430      802     +372     
  Lines      196333   282114   +85781     
  Branches    29897    54349   +24452     
==========================================
+ Hits       181849   255886   +74037     
- Misses      14159    16369    +2210     
- Partials      325     9859    +9534     
Files with missing lines Coverage Δ
lib/internal/url.js 93.76% <100.00%> (+11.62%) ⬆️

... and 530 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcollina
mcollina force-pushed the fix-urltohttpoptions-options-injection branch from 75bfa0e to 19b7a66 Compare November 13, 2026 14:58
Only spread own enumerable properties for URL instances created by this
realm's URL constructor. Duck-typed objects accepted by isURL() can no
longer smuggle connection options (socketPath, method, headers, agent)
into a request.

This fixes a footgun where a hostname-validated http.request() could be
redirected to a Unix socket (e.g. the Docker daemon) via a URL-shaped
object, bypassing hostname-based SSRF checks. Extending a genuine URL
object with extra options is preserved.

PR-URL: nodejs#67454
Refs: nodejs#46989
Signed-off-by: Matteo Collina <hello@matteocollina.com>
@mcollina
mcollina force-pushed the fix-urltohttpoptions-options-injection branch from 19b7a66 to edbd599 Compare November 13, 2026 15:27
@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 14, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 14, 2026
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. whatwg-url Issues and PRs related to the WHATWG URL implementation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants