Repository navigation
test: deflake test-tls-resume-servername - #67450
Merged
nodejs-github-bot merged 1 commit intoNov 15, 2026
Merged
nodejs-github-bot merged 1 commit into
nodejs-github-bot merged 1 commit into
Conversation
The PSK server's pskCallback answered every identity, but OpenSSL also asks it about the resumption ticket, cut at its first NUL byte. When that prefix is valid UTF-8, about 1% of the time, the ticket was taken for an external PSK and the handshake failed with decrypt_error. Only answer for the identity the client sends. Signed-off-by: Christian Aurich Zanettini Martins <christian.aurichzm@gmail.com>
Collaborator
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #67450 +/- ##
==========================================
- Coverage 90.71% 90.71% -0.01%
==========================================
Files 801 802 +1
Lines 281889 282109 +220
Branches 54315 54354 +39
==========================================
+ Hits 255709 255906 +197
- Misses 16307 16327 +20
- Partials 9873 9876 +3 🚀 New features to boost your workflow:
|
panva
approved these changes
Nov 13, 2026
Collaborator
Collaborator
jasnell
approved these changes
Nov 14, 2026
Collaborator
Contributor
Failed to resume CI
Full Auto Start CI output |
lpinca
approved these changes
Nov 14, 2026
LiviaMedeiros
approved these changes
Nov 14, 2026
Collaborator
|
Landed in 80fc1ef |
aduh95
pushed a commit
that referenced
this pull request
Nov 16, 2026
The PSK server's pskCallback answered every identity, but OpenSSL also asks it about the resumption ticket, cut at its first NUL byte. When that prefix is valid UTF-8, about 1% of the time, the ticket was taken for an external PSK and the handshake failed with decrypt_error. Only answer for the identity the client sends. Signed-off-by: Christian Aurich Zanettini Martins <christian.aurichzm@gmail.com> PR-URL: #67450 Refs: nodejs/reliability#1722 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test-tls-resume-servernamefails intermittently withERR_SSL_TLSV1_ALERT_DECRYPT_ERROR, on 6 PRs in the latest reliability report.On resumption, OpenSSL also passes the session ticket to the server's PSK callback as an identity, cut at its first NUL byte, and Node forwards it to
pskCallbackwhen that prefix is valid UTF-8. The test's callback returned the key for any identity, so the ticket was taken for an external PSK and the handshake failed. This only answers for'client'.Against the 2026-11-11 nightly, which predates the SNI change, the PSK part of the test fails 24/2000 runs before this change and 0/2000 after.
Refs: nodejs/reliability#1722