quic: fixes undefined handle in QuicStream kInspect#64170
Merged
nodejs-github-bot merged 1 commit intoJul 2, 2026
Conversation
If the #handle is undefined and not QuicStream, while kInspect is called `DataViewPrototypeGetByteLength` will throw. Signed-off-by: Marten Richter <marten.richter@freenet.de>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
Contributor
Author
jasnell
approved these changes
Jun 27, 2026
gurgunday
approved these changes
Jun 28, 2026
mertcanaltin
approved these changes
Jun 28, 2026
pimterry
approved these changes
Jun 30, 2026
github-actions
Bot
removed
the
request-ci
Collaborator
Collaborator
pimterry
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 87d6386 |
richardlau
pushed a commit
that referenced
this pull request
Jul 3, 2026
If the #handle is undefined and not QuicStream, while kInspect is called `DataViewPrototypeGetByteLength` will throw. Signed-off-by: Marten Richter <marten.richter@freenet.de> PR-URL: #64170 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: Tim Perry <pimterry@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the #handle is undefined and not QuicStream,
while kInspect is called
DataViewPrototypeGetByteLengthwill throw.