Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: stop distributing Corepack #57617

Closed
wants to merge 2 commits into from
+4 −4
Closed

build: stop distributing Corepack #57617

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2369ae9
build: stop distributing Corepack
aduh95 Mar 24, 2025
d2daeb7
Update configure.py
aduh95 Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions configure.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -813,11 +813,11 @@
default=None,
help='do not install the bundled npm (package manager)')

parser.add_argument('--without-corepack',
parser.add_argument('--with-corepack',
action='store_true',
dest='without_corepack',
dest='with_corepack',
default=None,
help='do not install the bundled Corepack')
help='do install the bundled Corepack (experimental, will be removed without notice)')

parser.add_argument('--control-flow-guard',
action='store_true',
Expand Down Expand Up @@ -1448,7 +1448,7 @@ def configure_node(o):
o['variables']['OS'] = 'android'
o['variables']['node_prefix'] = options.prefix
o['variables']['node_install_npm'] = b(not options.without_npm)
o['variables']['node_install_corepack'] = b(not options.without_corepack)
o['variables']['node_install_corepack'] = b(options.with_corepack)
o['variables']['control_flow_guard'] = b(options.enable_cfg)
o['variables']['node_use_amaro'] = b(not options.without_amaro)
o['variables']['debug_node'] = b(options.debug_node)
Expand Down
Loading