Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test,crypto: make tests work for BoringSSL #57021

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test,crypto: make tests work for BoringSSL #57021

wants to merge 1 commit into from
+2 −2

Conversation

codebytere
Copy link
Member

Refs #56559

Allows this test to pass with both BoringSSL and OpenSSL.

@codebytere codebytere requested a review from jasnell February 13, 2025 08:59
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Feb 13, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 13, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.10%. Comparing base (b7ca23f) to head (a49acf9).
Report is 15 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #57021      +/-   ##
==========================================
- Coverage   89.12%   89.10%   -0.02%     
==========================================
  Files         665      665              
  Lines      193191   193193       +2     
  Branches    37213    37212       -1     
==========================================
- Hits       172175   172142      -33     
- Misses      13757    13777      +20     
- Partials     7259     7274      +15

see 42 files with indirect coverage changes

@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 13, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 13, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65178/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65190/

mhdawson
mhdawson approved these changes Feb 13, 2025
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@richardlau richardlau richardlau approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
commit-queue Add this label to land a pull request using GitHub Actions. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@codebytere @nodejs-github-bot @jasnell @lpinca @richardlau @mhdawson