Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: add config file support #57016

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

src: add config file support #57016

wants to merge 1 commit into from

Conversation

marco-ippolito
Copy link
Member

@marco-ippolito marco-ippolito commented Feb 12, 2025 •
edited
Loading

Refs: #53787

NOT READY FOR REVIEW, JUST FOR FEEDBACK

If the initial approach is correct, I'll be happy to implement more flags

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/startup

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Feb 12, 2025
@anonrig
Copy link
Member

anonrig commented Feb 12, 2025

I took a somewhat similar approach last year. Happy to talk in private if you need any help. Ref: anonrig#4

@richardlau richardlau added the semver-minor PRs that contain new features and should be released in the next minor version. label Feb 12, 2025
@marco-ippolito marco-ippolito force-pushed the feat/config-file branch 2 times, most recently from 272828d to 497298b Compare February 12, 2025 21:53
anonrig
anonrig reviewed Feb 12, 2025
View reviewed changes
src/node_rc.cc Outdated Show resolved Hide resolved
@marco-ippolito marco-ippolito force-pushed the feat/config-file branch 3 times, most recently from 5342c22 to 2e99027 Compare February 12, 2025 22:20
marco-ippolito
marco-ippolito commented Feb 12, 2025
View reviewed changes
src/node_rc.cc
} else {
*node_options = result[0];
for (size_t i = 1; i < result.size(); ++i) {
*node_options += " " + result[i];
Copy link
Member Author

@marco-ippolito marco-ippolito Feb 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit dangerous since someone could do something like

"import": [
 "./foo.js --some-other-flag"
]

And the other flag will be evaluated 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig left review comments

@joyeecheung joyeecheung Awaiting requested review from joyeecheung

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. semver-minor PRs that contain new features and should be released in the next minor version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marco-ippolito @nodejs-github-bot @anonrig @richardlau