Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix GN build failure #57013

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

build: fix GN build failure #57013

wants to merge 1 commit into from

Conversation

zcbenz
Copy link
Contributor

@zcbenz zcbenz commented Feb 12, 2025

Disable a clang warning caused by #54990:

../../node/src/node_options.cc:60:20: error: loop variable 'entry' binds to a temporary value produced by a range of type 'decltype(split_view<views::all_t<string &>, views::all_t<string_view>>(std::forward<std::string &>(__range), std::forward<std::string_view>(__pattern)))' (aka 'split_view<ref_view<std::string>, std::string_view>') [-Werror,-Wrange-loop-bind-reference]
   60 |   for (const auto& entry : entries) {
      |                    ^
../../node/src/node_options.cc:60:8: note: use non-reference type 'value_type' (aka 'subrange<std::__wrap_iter<char *>>')
   60 |   for (const auto& entry : entries) {
      |        ^~~~~~~~~~~~~~~~~~~

According to discussions at https://huixie90.github.io/wrange-loop-analysis/, I think the code is totally valid and we should not modify code to work around the warning.

Also fix zstd dep.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants