Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: handle UV_ENOTDIR in is_uv_error_except_no_entry #56996

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fs: handle UV_ENOTDIR in is_uv_error_except_no_entry #56996

wants to merge 1 commit into from
+14 −2

Conversation

juanarbol
Copy link
Member

Fixes: #56993

@juanarbol juanarbol added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 10, 2025
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Feb 10, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 10, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65128/

@codecov Codecov
Copy link

codecov bot commented Feb 10, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.10%. Comparing base (85f5a6c) to head (2397ca2).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
src/node_file.cc 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #56996      +/-   ##
==========================================
- Coverage   89.11%   89.10%   -0.01%     
==========================================
  Files         665      665              
  Lines      193193   193196       +3     
  Branches    37212    37209       -3     
==========================================
- Hits       172158   172151       -7     
+ Misses      13775    13772       -3     
- Partials     7260     7273      +13
Files with missing lines Coverage Δ
src/node_file.cc 76.92% <80.00%> (+0.02%) ⬆️

... and 23 files with indirect coverage changes

addaleax
addaleax requested changes Feb 11, 2025
View reviewed changes
src/node_file.cc Outdated Show resolved Hide resolved
@juanarbol juanarbol force-pushed the juan/statsync-no-throw branch from 4a62a75 to f2ef348 Compare February 11, 2025 20:16
@juanarbol
Copy link
Member Author

cc// @Ceres6

@juanarbol juanarbol force-pushed the juan/statsync-no-throw branch from f2ef348 to 985b3a3 Compare February 12, 2025 20:44
@juanarbol juanarbol added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Feb 12, 2025
@juanarbol juanarbol force-pushed the juan/statsync-no-throw branch from 985b3a3 to 2397ca2 Compare February 12, 2025 20:48
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65161/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65167/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65193/

@juanarbol juanarbol added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 14, 2025
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 14, 2025
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/56996
✔  Done loading data for nodejs/node/pull/56996
----------------------------------- PR info ------------------------------------
Title      fs: handle UV_ENOTDIR in `is_uv_error_except_no_entry` (#56996)
Author     Juan José <[email protected]> (@juanarbol)
Branch     juanarbol:juan/statsync-no-throw -> nodejs:main
Labels     c++, fs, author ready, needs-ci
Commits    1
 - fs: handle UV_ENOTDIR in `fs.statSync` with `throwIfNoEntry` provided
Committers 1
 - Juan José Arboleda <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/56996
Fixes: https://github.com/nodejs/node/issues/56993
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/56996
Fixes: https://github.com/nodejs/node/issues/56993
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - fs: handle UV_ENOTDIR in `fs.statSync` with `throwIfNoEntry` provided
   ℹ  This PR was created on Mon, 10 Feb 2025 17:19:26 GMT
   ✔  Approvals: 2
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/56996#pullrequestreview-2606783699
   ✔  - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/56996#pullrequestreview-2610090803
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2025-02-13T21:19:39Z: https://ci.nodejs.org/job/node-test-pull-request/65193/
- Querying data for job/node-test-pull-request/65193/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/13336321966

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@anonrig anonrig anonrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

statSync with throwIfNoEntry: false still throws ENOTDIR
4 participants
@juanarbol @nodejs-github-bot @addaleax @anonrig