Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: add support for import source syntax in linter #56992

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Feb 10, 2025

It's going to be useful for #56919, IMO it makes sense to put it in a separate PR to avoid backporting issues.

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Feb 10, 2025
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 11, 2025
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 12, 2025
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/56992
✔  Done loading data for nodejs/node/pull/56992
----------------------------------- PR info ------------------------------------
Title      tools: add support for `import source` syntax in linter (#56992)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     aduh95:source-import-lint -> nodejs:main
Labels     tools, author ready
Commits    1
 - tools: add support for `import source` syntax in linter
Committers 1
 - Antoine du Hamel <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/56992
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/56992
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 10 Feb 2025 15:01:43 GMT
   ✔  Approvals: 2
   ✔  - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/56992#pullrequestreview-2607474292
   ✔  - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/56992#pullrequestreview-2608054594
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 56992
From https://github.com/nodejs/node
 * branch                  refs/pull/56992/merge -> FETCH_HEAD
✔  Fetched commits as e7626dc70dbd..50a20ea40d52
--------------------------------------------------------------------------------
Auto-merging tools/eslint/package-lock.json
CONFLICT (content): Merge conflict in tools/eslint/package-lock.json
Auto-merging tools/eslint/package.json
CONFLICT (content): Merge conflict in tools/eslint/package.json
error: could not apply 50a20ea40d... tools: add support for `import source` syntax in linter
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
   ✘  Failed to apply patches
https://github.com/nodejs/node/actions/runs/13288558054

@aduh95 aduh95 force-pushed the source-import-lint branch from 50a20ea to 1ede719 Compare February 12, 2025 16:37
@aduh95 aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Feb 12, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 12, 2025
@nodejs-github-bot nodejs-github-bot merged commit a7f648c into nodejs:main Feb 12, 2025
20 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in a7f648c

@aduh95 aduh95 deleted the source-import-lint branch February 12, 2025 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants