doc: update history of stream.Readable.toWeb() #56928
Merged
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
hkleungai
commented
Feb 5, 2025
| - version: | ||
| - v19.0.0 | ||
| - v18.7.0 | ||
| pr-url: https://github.com/nodejs/node/pull/43515 |
There was a problem hiding this comment.
Seems there is a warning from GitHub Actions / lint-pr-url. If this url needs to be changed please let me know.
Open
7 tasks
lpinca
approved these changes
Feb 6, 2025
Adds the exact version for when the 2nd `options` argument is available. Refs: nodejs#43515
hkleungai
force-pushed
the
stream-Writable-fromWeb-history-update
branch
from
50e796a to
2419b31
Compare
lpinca
approved these changes
Feb 6, 2025
lpinca
added
the
author ready
jasnell
approved these changes
Feb 7, 2025
lpinca
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 1b2d2f7 |
targos
pushed a commit
that referenced
this pull request
Feb 10, 2025
Adds the exact version for when the 2nd `options` argument is available. Refs: #43515 PR-URL: #56928 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the exact version for when the 2nd
optionsargument is available.Refs: #43515