-
Notifications
You must be signed in to change notification settings - Fork 30.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fs: fix fs.promises.mkdir to also report ENOSPC correctly #56918
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56918 +/- ##
==========================================
- Coverage 89.18% 89.16% -0.03%
==========================================
Files 665 665
Lines 192543 192574 +31
Branches 37045 37085 +40
==========================================
- Hits 171726 171702 -24
- Misses 13636 13658 +22
- Partials 7181 7214 +33
|
29f8542
to
008577c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSLGTM
looks like two test failures for the test runner itself, i think its unrelated to the changeset, are those two known to flake? |
Continuation of #42811 which fixes #42808 for the async case
Happy to try to write a test but left as is for now seeing as the previous PR also didn't: #42811 (review)