Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs: fix fs.promises.mkdir to also report ENOSPC correctly #56918

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jackyzha0
Copy link

Continuation of #42811 which fixes #42808 for the async case

Happy to try to write a test but left as is for now seeing as the previous PR also didn't: #42811 (review)

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Feb 5, 2025
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.16%. Comparing base (316ac8c) to head (008577c).
Report is 78 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #56918      +/-   ##
==========================================
- Coverage   89.18%   89.16%   -0.03%     
==========================================
  Files         665      665              
  Lines      192543   192574      +31     
  Branches    37045    37085      +40     
==========================================
- Hits       171726   171702      -24     
- Misses      13636    13658      +22     
- Partials     7181     7214      +33     
Files with missing lines Coverage Δ
src/node_file.cc 77.19% <ø> (-0.05%) ⬇️

... and 39 files with indirect coverage changes

@jackyzha0 jackyzha0 force-pushed the jackyzha0/enoent-mkdir-async branch from 29f8542 to 008577c Compare February 5, 2025 20:31
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 7, 2025
Copy link
Member

@lpinca lpinca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 7, 2025
@nodejs-github-bot
Copy link
Collaborator

@jackyzha0
Copy link
Author

looks like two test failures for the test runner itself, i think its unrelated to the changeset, are those two known to flake?

@jackyzha0
Copy link
Author

@addaleax @lpinca sorry for the tag but let me know if theres anything else I need to do here on my end, I can't seem to be able to re-run CI on my own

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65159/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fs.mkdirSync with recursive: true throws ENOENT instead of ENOSPC when disk is full
4 participants