Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update sqlite to 3.49.0 #56654

Merged
merged 1 commit into from
Feb 9, 2025
Merged

Conversation

nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot commented Jan 19, 2025

This is an automated update of sqlite to 3.49.0.

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. sqlite Issues and PRs related to the SQLite subsystem. labels Jan 19, 2025
@nodejs-github-bot
Copy link
Collaborator Author

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jan 19, 2025
@nodejs-github-bot nodejs-github-bot force-pushed the actions/tools-update-sqlite branch from 66aa5f0 to 9584d00 Compare January 26, 2025 00:31
@targos
Copy link
Member

targos commented Jan 29, 2025

This seems to introduce a test failure:

=== release test-sqlite-session ===
Path: parallel/test-sqlite-session
Error: --- stderr ---
(node:175717) ExperimentalWarning: SQLite is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
--- stdout ---
Test failure: 'database.applyChangeset() - SQLITE_CHANGESET_FOREIGN_KEY conflict'
Location: test/parallel/test-sqlite-session.js:296:3
Error: constraint failed
    at TestContext.<anonymous> (/home/runner/work/node/node/node/test/parallel/test-sqlite-session.js:299:30)
    at Test.runInAsyncScope (node:async_hooks:211:14)
    at Test.run (node:internal/test_runner/test:980:25)
    at Suite.processPendingSubtests (node:internal/test_runner/test:678:18)
    at Test.postRun (node:internal/test_runner/test:1091:19)
    at Test.run (node:internal/test_runner/test:1019:12)
    at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
    at async Suite.processPendingSubtests (node:internal/test_runner/test:678:7) {
  code: 'ERR_SQLITE_ERROR',
  errcode: 19
}

Test failure: 'database.applyChangeset() - SQLITE_CHANGESET_FOREIGN_KEY conflict'
Location: test/parallel/test-sqlite-session.js:296:3
Error: constraint failed
    at TestContext.<anonymous> (/home/runner/work/node/node/node/test/parallel/test-sqlite-session.js:299:30)
    at Test.runInAsyncScope (node:async_hooks:211:14)
    at Test.run (node:internal/test_runner/test:980:25)
    at Suite.processPendingSubtests (node:internal/test_runner/test:678:18)
    at Test.postRun (node:internal/test_runner/test:1091:19)
    at Test.run (node:internal/test_runner/test:1019:12)
    at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
    at async Suite.processPendingSubtests (node:internal/test_runner/test:678:7) {
  code: 'ERR_SQLITE_ERROR',
  errcode: 19
}
Command: out/Release/node --experimental-sqlite --test-reporter=./test/common/test-error-reporter.js --test-reporter-destination=stdout --test-reporter=./test/common/test-error-reporter.js --test-reporter-destination=stdout /home/runner/work/node/node/node/test/parallel/test-sqlite-session.js

@cjihrig
Copy link
Contributor

cjihrig commented Jan 29, 2025

cc: @louwers since the failures are related to the session extension. Nothing from the changelog jumps out.

@louwers
Copy link
Contributor

louwers commented Jan 29, 2025

@cjihrig Will have a look.

@louwers
Copy link
Contributor

louwers commented Jan 29, 2025

I have reported this problem upstream. https://sqlite.org/forum/forumpost/adaff69331

Related: https://sqlite.org/forum/forumpost/247a184a9b

@cjihrig
Copy link
Contributor

cjihrig commented Jan 29, 2025

The SQLite team has confirmed it is a bug on their side: https://sqlite.org/forum/forumpost/00f3aab3d3be9690.

@louwers
Copy link
Contributor

louwers commented Jan 29, 2025

Yup, this will be fixed in the next SQLite release.

I suggest we just wait until the next patch release of SQLite is out.

@nodejs-github-bot nodejs-github-bot force-pushed the actions/tools-update-sqlite branch from 9584d00 to 74830ac Compare February 2, 2025 00:32
@targos targos added the blocked PRs that are blocked by other issues or PRs. label Feb 7, 2025
@nodejs-github-bot nodejs-github-bot force-pushed the actions/tools-update-sqlite branch from 74830ac to 756d2a6 Compare February 9, 2025 00:33
@nodejs-github-bot nodejs-github-bot changed the title deps: update sqlite to 3.48.0 deps: update sqlite to 3.49.0 Feb 9, 2025
@cjihrig cjihrig added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 9, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 9, 2025
@nodejs-github-bot
Copy link
Collaborator Author

@targos targos removed the blocked PRs that are blocked by other issues or PRs. label Feb 9, 2025
@targos targos added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 9, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 9, 2025
@nodejs-github-bot nodejs-github-bot merged commit bfa1765 into main Feb 9, 2025
54 checks passed
@nodejs-github-bot
Copy link
Collaborator Author

Landed in bfa1765

@nodejs-github-bot nodejs-github-bot deleted the actions/tools-update-sqlite branch February 9, 2025 09:55
targos pushed a commit that referenced this pull request Feb 10, 2025
PR-URL: #56654
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants